Adding all ASI RP APIs #5173

nirgfani · 2019-02-07T22:55:40Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…sight). This RP is an extension RP of "Microsoft.operationalinsights", and it is coupled to a Log analytics workspace. This is a first iteration in order to create a simple RP with single endpoint, after it wil work the API will be changed with the actual and full endpoints based on the learnings from this POC.

…eter and reuse it in the PUT same as in the GET

…sights

Merging from Azure Repo

…pecs

* Changing durations to fit standards * Changing operators to fit other RPs * Align naming to scheduledAlertRules * Adding 200 response to DeleteScheduledAlertRule

alertTriggerOperator => triggerOperator alertTriggerThreshold => triggerThreshold

Merge back

majastrz · 2019-02-11T20:26:49Z

                    "UebaSettings",

Please consider expanding the acronym on the enum value. UserAndEntityBehaviorAnalyticsSettings is probably too much, but BehaviorAnalyticsSettings would improve readability.

Refers to: specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json:2717 in 36b0f2d. [](commit_id = 36b0f2d, deletion_comment = False)

majastrz · 2019-02-11T20:29:26Z

                "description": "Determines whether the tenant .",

Incomplete description

Refers to: specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json:2768 in 36b0f2d. [](commit_id = 36b0f2d, deletion_comment = False)

majastrz · 2019-02-11T20:29:46Z

                "description": "Determines whether UEBA is enabled from MCAS.",

Please expand the acronym.

Refers to: specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json:2755 in 36b0f2d. [](commit_id = 36b0f2d, deletion_comment = False)

majastrz · 2019-02-11T20:50:54Z

                "description": "Determines whether the tenant .",

Also please expand ATP in the description once you add it.

In reply to: 462482230 [](ancestors = 462482230)

Refers to: specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json:2768 in 36b0f2d. [](commit_id = 36b0f2d, deletion_comment = False)

majastrz

🕐

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json

nirgfani · 2019-02-12T13:20:55Z

    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{operationalInsightsResourceProvider}/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/cases": {
This applies to all the extension resource types: What error message will the user get if they attempt to create the extension resource type at a scope that you don't support (something that's not an LA workspace)?

Refers to: specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json:516 in 36b0f2d. [](commit_id = 36b0f2d, deletion_comment = False)

@majastrz Without LA workspace it won't exist, in our code we are listening only on request that are being made on Microsoft.OperationalInsights RP-/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalIinsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/cases

nirgfani · 2019-02-12T13:23:54Z

@majastrz, @ravbhatnagar - I see that you both have questions regarding "actions", let's discuss it today on the meeting

nirgfani · 2019-02-12T14:18:33Z

        "x-ms-discriminator-value": "Account",
Have you verified that the SDK generated by the Swagger is capable of deserializing Entities of all kinds?

Refers to: specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json:2446 in 36b0f2d. [](commit_id = 36b0f2d, deletion_comment = False)

What's the different between it and other cases? What's your concern?
How do I run it? I ran the AutoReset and it pass.

Actions will be only nested resource at the moment, so ruleId is not needed currently. Patterns will be removed so Guid will not be mandatory as parameter. ruleName will be cahanged to displayName in AlertRules

ravbhatnagar · 2019-02-13T07:35:27Z

One design feedback needs to be revisited - currently, actions is a child type under alertRules. This means that to associate a webhook, or endpoint with multiple alertRules, multiple child resources of type actions must be created. This will result in management overhead for these resources. In future, service team will support actions under cases resource type as well. And the plan is to add this as a nested resource type under cases as well.
The recommendations were are follows -

Model actions as a top level resource type. and then it could be re-used/associated with any number of alertRules or cases
Model it as a property on the alertRules and cases. This may not be optimal when it needs to be an array and updating will not be straight forward.
Service team will consider this feedback after the preview release. potentially get feedback from customers and understand more how they use these actions.
SIgning off from ARM side with this note.

jhendrixMSFT

The JSON is malformed causing parsing failure, see the log.

package.json

jhendrixMSFT · 2019-02-13T16:16:33Z

@nirgfani also is the service deployed and live?

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json

* AvailabilitySet swagger changes and examples * Using struct for avSet props. * Updated availability set from array to object * Changing object to array of objects for vm

nirgfani and others added 30 commits December 31, 2018 15:00

updating the operationalInsightsResourceProvider to be a global param…

de2a4c9

…eter and reuse it in the PUT same as in the GET

Fixing comments from PR

8e0cd13

Fixing the Microsoft.OperationalInsight to the right form

7d0a4c7

Updating the location to be under- "resource-manager"

fd243ea

adding readme files for the swagger

f16db7f

Changing the path of the files to the correct path

1703e6f

Change the location of the readme files

36aca1e

Fixing inconsistency in the naming- changing everything to SecurityIn…

5326e67

…sights

Missed the file when aligned the name to SecurityInsights

a9475d1

Fixing a redundant space in the examples

93b148d

add alertRule to the CreateAlertRule.json and do some indentation fixes

73565ce

Merge pull request #1 from Azure/master

5ed047d

Merging from Azure Repo

Creates the "real" API for Scheduled Alert Rules

8808c18

Merge branch 'master' of https://github.com/nirgfani/azure-rest-api-s…

b63cbf7

…pecs

Update the name alertRule to alertScheduledtRule in the creation example

12beca7

Fixing comments from PR-

1d1029b

* Changing durations to fit standards * Changing operators to fit other RPs * Align naming to scheduledAlertRules * Adding 200 response to DeleteScheduledAlertRule

Changing naming-

863597a

alertTriggerOperator => triggerOperator alertTriggerThreshold => triggerThreshold

Adding kind to AlertRule and making Scheduled as a specific kind

573869d

Fix some errors

27d8376

Trying to solve the model validator issues

0f74576

Fixing indentation

831ec10

Adding data connectors endpoints

37aea3e

Merge pull request #2 from Azure/master

26f94da

Merge back

Merge branch 'master' into Backup

32dd110

fixing nesting issues

142e088

Try to fix some checks issues

1a6ebaa

Try to fix issues once again

8520972

Fixing typos

c69c6aa

Add actions for alerts

48186e8

majastrz requested changes Feb 11, 2019

View reviewed changes

ravbhatnagar suggested changes Feb 12, 2019

View reviewed changes

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 12, 2019

Fixing comments from PR

ceed874

nirgfani added 3 commits February 12, 2019 17:16

Change in dataConnectors from contextId to the relevant ID

04b7d63

Fixing the code according to discussion.

8af921b

Actions will be only nested resource at the moment, so ruleId is not needed currently. Patterns will be removed so Guid will not be mandatory as parameter. ruleName will be cahanged to displayName in AlertRules

Fixing validation error

455c9b4

jhendrixMSFT requested changes Feb 13, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

nirgfani added 2 commits February 13, 2019 18:41

revert this file

b85f87a

Fixing examples json

4b51311

jhendrixMSFT reviewed Feb 13, 2019

View reviewed changes

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved

jhendrixMSFT reviewed Feb 13, 2019

View reviewed changes

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved

updating the operationIds to be more precise

22bf302

jhendrixMSFT approved these changes Feb 13, 2019

View reviewed changes

ravbhatnagar approved these changes Feb 13, 2019

View reviewed changes

majastrz approved these changes Feb 13, 2019

View reviewed changes

jhendrixMSFT merged commit 64f1e0e into Azure:master Feb 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding all ASI RP APIs #5173

Adding all ASI RP APIs #5173

nirgfani commented Feb 7, 2019

majastrz commented Feb 11, 2019

majastrz commented Feb 11, 2019

majastrz commented Feb 11, 2019

majastrz commented Feb 11, 2019

majastrz left a comment

nirgfani commented Feb 12, 2019 •

edited

Loading

nirgfani commented Feb 12, 2019

nirgfani commented Feb 12, 2019

ravbhatnagar commented Feb 13, 2019

jhendrixMSFT left a comment

jhendrixMSFT commented Feb 13, 2019

Adding all ASI RP APIs #5173

Adding all ASI RP APIs #5173

Conversation

nirgfani commented Feb 7, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

majastrz commented Feb 11, 2019

majastrz commented Feb 11, 2019

majastrz commented Feb 11, 2019

majastrz commented Feb 11, 2019

majastrz left a comment

Choose a reason for hiding this comment

nirgfani commented Feb 12, 2019 • edited Loading

nirgfani commented Feb 12, 2019

nirgfani commented Feb 12, 2019

ravbhatnagar commented Feb 13, 2019

jhendrixMSFT left a comment

Choose a reason for hiding this comment

jhendrixMSFT commented Feb 13, 2019

nirgfani commented Feb 12, 2019 •

edited

Loading