Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QnAMaker DTO changes for Multiturn #5738

Merged
merged 7 commits into from Apr 24, 2019
Merged

QnAMaker DTO changes for Multiturn #5738

merged 7 commits into from Apr 24, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 23, 2019 •
edited by ghost
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@ghost ghost requested review from DavidLiCIG and yangyuan as code owners April 23, 2019 16:27
@azuresdkci azuresdkci requested a review from praries880 April 23, 2019 16:28
@AutorestCI AutorestCI mentioned this pull request Apr 23, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#2466

@AutorestCI
Copy link

AutorestCI commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2420

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@adxsdknet
Copy link

adxsdknet commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5909
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@f607d8d
adxsdknet/azure-sdk-for-net@f40aa49

@AutorestCI AutorestCI mentioned this pull request Apr 23, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4951

@AutorestCI AutorestCI mentioned this pull request Apr 23, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4654

@AutorestCI AutorestCI mentioned this pull request Apr 23, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 23, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3453

@dsgouda
Copy link
Contributor

dsgouda commented Apr 24, 2019

@praries880 Taking over

@dsgouda dsgouda assigned dsgouda and unassigned praries880 Apr 24, 2019
@dsgouda dsgouda requested review from dsgouda and removed request for praries880 April 24, 2019 16:42
@AutorestCI AutorestCI mentioned this pull request Apr 24, 2019
Merged
@dsgouda
Copy link
Contributor

dsgouda commented Apr 24, 2019

@sarangan12 Could you please take a look at the Ruby SDK failures?

dsgouda
dsgouda approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge once CIs pass

This was referenced Apr 24, 2019
Merged
Merged
@dsgouda dsgouda merged commit 7934116 into Azure:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidLiCIG DavidLiCIG Awaiting requested review from DavidLiCIG

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan is a code owner

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AutorestCI @azuresdkci @adxsdknet @dsgouda @praries880 @sarangan12