Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AWS CloudTrail to swagger #6122

Merged
merged 5 commits into from
Jul 15, 2019
Merged

Adding AWS CloudTrail to swagger #6122

merged 5 commits into from
Jul 15, 2019

Conversation

mahmoudraedhasanmsft
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented May 27, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci azuresdkci requested a review from shahabhijeet May 27, 2019 09:33
@AutorestCI AutorestCI mentioned this pull request May 27, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented May 27, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5722

@AutorestCI
Copy link

AutorestCI commented May 27, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request May 27, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented May 27, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request May 27, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented May 27, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5246

This was referenced May 29, 2019
Closed
Closed
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 006f635)

Succeeded Go: Azure/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Succeeded JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@AutorestCI AutorestCI mentioned this pull request Jun 12, 2019
Merged
@mahmoudraedhasanmsft
Copy link
Contributor Author

@shahabhijeet please review my PR. thanks

@loarabia
Copy link

@shahabhijeet this looks like it is getting stale is there a blocker?

@mahmoudraedhasanmsft
Copy link
Contributor Author

Hi @loarabia , @shahabhijeet ,
Who can review this PR?
Thanks

@sanjaiganesh sanjaiganesh added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 8, 2019
@mahmoudraedhasanmsft
Copy link
Contributor Author

@shahabhijeet I think it should be the same like the other connectors.
@nirgfani , what do you think?

@mahmoudraedhasanmsft
Copy link
Contributor Author

@shahabhijeet , I checked it with my team and it's ok. Please approve if you see that everything is OK.

@mahmoudraedhasanmsft
Copy link
Contributor Author

@loarabia can you please approve the PR?

@shahabhijeet shahabhijeet merged commit 94efc12 into Azure:master Jul 15, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@mahmoudraedhasanmsft @celikcigdem
Adding AWS CloudTrail to swagger (Azure#6122)
ac09ce1 
* Adding AWS CloudTrail to swagger

* Code review notes

* Code review notes

* Fixes after merge
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@raych1
Sync common-types from public main (#6122)
e5d43f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Assignees

@shahabhijeet shahabhijeet

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mahmoudraedhasanmsft @AutorestCI @azuresdkci @loarabia @shahabhijeet @sanjaiganesh