Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed partitionIds type in EventHub #613

Merged
merged 1 commit into from
Oct 22, 2016
Merged

Conversation

mcardosos
Copy link
Contributor

@mcardosos mcardosos commented Oct 20, 2016

Based on documentation here.
This should fix this bug in the Go SDK.
@sazeesha @jhendrixMSFT

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

  • I have read the contribution guidelines.
  • My spec meets the review criteria:
    • The spec conforms to the Swagger 2.0 specification.
    • Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
    • The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

This change is Reviewable

@sazeesha
Copy link
Contributor

@mcardosos this change looks good.

@mcardosos
Copy link
Contributor Author

@amarzavery Can we merge this?

@amarzavery
Copy link
Contributor

@lmazuel
The CI is failing for python. Can you take a look ?

mono /tmp/tmp9oxm94qm/autorest/tools/AutoRest.exe -i /git-restapi/arm-eventhub/2015-08-01/swagger/EventHub.json -o /tmp/tmp9oxm94qm/EventHub.json -AddCredentials True -CodeGenerator Azure.Python -Header MICROSOFT_MIT_NO_VERSION -Namespace azure.mgmt.eventhub -PackageVersion 0.1.0 -ft 2
ERROR:__main__:Command '['mono', '/tmp/tmp9oxm94qm/autorest/tools/AutoRest.exe', '-i', '/git-restapi/arm-eventhub/2015-08-01/swagger/EventHub.json', '-o', '/tmp/tmp9oxm94qm/EventHub.json', '-AddCredentials', 'True', '-CodeGenerator', 'Azure.Python', '-Header', 'MICROSOFT_MIT_NO_VERSION', '-Namespace', 'azure.mgmt.eventhub', '-PackageVersion', '0.1.0', '-ft', '2']' returned non-zero exit status 1
ERROR:__main__:Code generation failed.
AutoRest.exe -i /git-restapi/arm-eventhub/2015-08-01/swagger/EventHub.json -o /tmp/tmp9oxm94qm/EventHub.json -AddCredentials True -CodeGenerator Azure.Python -Header MICROSOFT_MIT_NO_VERSION -Namespace azure.mgmt.eventhub -PackageVersion 0.1.0 -ft 2
FATAL: Error loading Azure.Python assembly: Could not load file or assembly 'AutoRest.Python.Azure.dll' or one of its dependencies

Traceback (most recent call last):
  File "/SwaggerToSdk.py", line 631, in <module>
    main()
  File "/SwaggerToSdk.py", line 628, in main
    args.autorest_dir)
  File "/SwaggerToSdk.py", line 544, in build_libraries
    autorest_exe_path, global_conf, local_conf)
  File "/SwaggerToSdk.py", line 162, in generate_code
    cwd=str(swagger_path))
  File "/usr/lib/python3.4/subprocess.py", line 620, in check_output
    raise CalledProcessError(retcode, process.args, output=output)
subprocess.CalledProcessError: Command '['mono', '/tmp/tmp9oxm94qm/autorest/tools/AutoRest.exe', '-i', '/git-restapi/arm-eventhub/2015-08-01/swagger/EventHub.json', '-o', '/tmp/tmp9oxm94qm/EventHub.json', '-AddCredentials', 'True', '-CodeGenerator', 'Azure.Python', '-Header', 'MICROSOFT_MIT_NO_VERSION', '-Namespace', 'azure.mgmt.eventhub', '-PackageVersion', '0.1.0', '-ft', '2']' returned non-zero exit status 1

@mcardosos
Copy link
Contributor Author

I think @fearthecowboy knows what's happening

@amarzavery amarzavery merged commit 1988a0a into Azure:master Oct 22, 2016
@AutorestCI
Copy link

@AutorestCI
Copy link

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in the Event Hubs SDK
5 participants