Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDI add autoscale feature support #6158

Merged
merged 6 commits into from
Jun 25, 2019
Merged

HDI add autoscale feature support #6158

merged 6 commits into from
Jun 25, 2019

Conversation

gaoxiaoninghit
Copy link
Contributor

@gaoxiaoninghit gaoxiaoninghit commented May 30, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented May 30, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request May 30, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented May 30, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6082

@AutorestCI AutorestCI mentioned this pull request May 30, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented May 30, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3696

@AutorestCI
Copy link

AutorestCI commented May 30, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3285

@AutorestCI AutorestCI mentioned this pull request May 30, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented May 30, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5106

@gaoxiaoninghit gaoxiaoninghit changed the title Hdi add autoscale support autorest HDI add autoscale feature support May 30, 2019
@azuresdkci azuresdkci requested a review from NelsonDaniel May 30, 2019 06:55
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@gaoxiaoninghit gaoxiaoninghit force-pushed the hdi_add_autoscale_support_autorest branch from e35e81d to 5692d42 Compare May 30, 2019 07:33
@idear1203 idear1203 self-requested a review May 31, 2019 04:57
idear1203
idear1203 approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@idear1203 idear1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

NelsonDaniel
NelsonDaniel suggested changes Jun 3, 2019
View reviewed changes
Copy link

@NelsonDaniel NelsonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some review comments. Also, solve merge conflicts

@NelsonDaniel
Copy link

NelsonDaniel commented Jun 11, 2019 •
edited
Loading

Merge conflicts need to be resolved.

@NelsonDaniel NelsonDaniel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 11, 2019
@gaoxiaoninghit gaoxiaoninghit force-pushed the hdi_add_autoscale_support_autorest branch from cc046e5 to 64381fd Compare June 12, 2019 05:51
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from edd2f70)

Succeeded Go: Azure/azure-sdk-for-go [Logs] [Diff]
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Succeeded JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Jun 12, 2019
Closed
@gaoxiaoninghit gaoxiaoninghit force-pushed the hdi_add_autoscale_support_autorest branch from 64381fd to a1be505 Compare June 12, 2019 05:55
@NelsonDaniel
Copy link

Looks good to me. Just waiting for ARM feedback. Need to reassign this PR since I will be OOF, and this needs to be merged before I come back

@azuresdkci azuresdkci requested a review from amarzavery June 12, 2019 21:08
@amarzavery
Copy link
Contributor

@gaoxiaoning - New model types have been added to the swagger specification. I don't see any updates to the corresponding x-ms-examples in the operation where these types are being used. Please update the existing examples or add new examples that show the usage of newly added model types.

majastrz
majastrz approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 17, 2019
This was referenced Jun 19, 2019
Merged
Merged
Merged
@idear1203
Copy link
Contributor

@amarzavery , could you please help merge the PR or let us know if you have other concerns:)

@amarzavery amarzavery merged commit 047450d into Azure:master Jun 25, 2019
@aim-for-better aim-for-better mentioned this pull request Aug 13, 2019
Merged
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@Basant2619
Removed unused properties and renamed example folder (#6158)
fbec1fb 
* removed unused properties and renamed example folder

* removed provider version property

* undone readme changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarzavery amarzavery amarzavery approved these changes

@idear1203 idear1203 idear1203 approved these changes

@NelsonDaniel NelsonDaniel NelsonDaniel approved these changes

@majastrz majastrz majastrz approved these changes

Assignees

@amarzavery amarzavery

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review HDInsight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gaoxiaoninghit @AutorestCI @azuresdkci @NelsonDaniel @amarzavery @idear1203 @majastrz