-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Factory: fixed readme, added java readme #6431
Conversation
SDK Automation [Logs] (Generated from 2ac94d2)
|
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Can one of the admins verify this patch? |
@iscai-msft could you give some more details on the purpose of the fixes in readme file? |
@zikalino I realize the file changes seem big but in actuality there isn't much change, I just decomposed the Java section into a separate readme for readability and fixed the namespace of datafactory in java from datafactoryv2 to just datafactory. You are right, it does seem to be failing the azure-sdk-for-java CI but I checked and that's because of an autorest error which I've filed an issue for, and shouldn't be due to the readme changes. Hope this answers your questions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, looks good
@zhangyd2015 ok to merge? |
@hvermis to add comments. |
No description provided.