Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Factory: fixed readme, added java readme #6431

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

iscai-msft
Copy link
Contributor

No description provided.

@iscai-msft iscai-msft requested a review from praries880 June 24, 2019 20:16
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2019

SDK Automation [Logs] (Generated from 2ac94d2)

Failed Python: Azure/azure-sdk-for-python [Logs]
  • No packages generated.
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: Azure/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3084

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@zikalino
Copy link

@iscai-msft could you give some more details on the purpose of the fixes in readme file?
Seems like the resulting change is huge and in addition CI here seems to be failing: Azure/azure-sdk-for-java#3084

@iscai-msft
Copy link
Contributor Author

@zikalino I realize the file changes seem big but in actuality there isn't much change, I just decomposed the Java section into a separate readme for readability and fixed the namespace of datafactory in java from datafactoryv2 to just datafactory.

You are right, it does seem to be failing the azure-sdk-for-java CI but I checked and that's because of an autorest error which I've filed an issue for, and shouldn't be due to the readme changes.

Hope this answers your questions!

Copy link

@zikalino zikalino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, looks good

@zikalino
Copy link

zikalino commented Jul 3, 2019

@zhangyd2015 ok to merge?

@zhangyd2015
Copy link
Contributor

@zhangyd2015 ok to merge?

@hvermis to add comments.

@zikalino zikalino merged commit 547d9bd into Azure:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants