Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introducing the SqlManagement in Microsoft.SqlVirtualMachine #6524

Merged
merged 7 commits into from
Jul 2, 2019
Merged

introducing the SqlManagement in Microsoft.SqlVirtualMachine #6524

merged 7 commits into from
Jul 2, 2019

Conversation

SeliuMSFT
Copy link
Contributor

@SeliuMSFT SeliuMSFT commented Jul 1, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@SeliuMSFT SeliuMSFT requested a review from yareyes July 1, 2019 20:58
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from f26d0f7)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jul 1, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jul 1, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 1, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5768

@azuresdkci azuresdkci requested a review from praries880 July 1, 2019 21:00
@AutorestCI
Copy link

AutorestCI commented Jul 1, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jul 1, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 1, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5180

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@SeliuMSFT
Copy link
Contributor Author

SeliuMSFT commented Jul 1, 2019 •
edited
Loading

@praries880 could you help to take a look at this change? we need to this out sooner than later to unblock an announcement this week.

@nschonni
Copy link
Contributor

nschonni commented Jul 2, 2019

If you want to use "LUNs" instead of "LUN", you might need to add the word to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt

@praries880
Copy link

@SeliuMSFT Kindly fix the spelling mistakes pointed out in :
https://dev.azure.com/azure-sdk/public/_build/results?buildId=60485&view=logs&j=eca5a1cb-f12a-57d8-9254-390bd587c201&t=be275096-42fe-5449-ec4b-01c6f327d2b3&l=18

To whitelist "LUNs" you will need to update : https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt

@praries880 praries880 merged commit 8a69874 into Azure:master Jul 2, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@SeliuMSFT @celikcigdem
introducing the SqlManagement in Microsoft.SqlVirtualMachine (Azure#6524
0da657c 
)

* introducing the SqlManagement

* update the type.

* fixing the typo for LUN

* fixing the LUNs again.

* fixing the lun

* update the LUNs to LUN

* Fixing the LUNs to LUN again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praries880 praries880 praries880 approved these changes

@yareyes yareyes yareyes approved these changes

Assignees

@praries880 praries880

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SeliuMSFT @AutorestCI @azuresdkci @nschonni @praries880 @yareyes