initial VMware by Virtustream preview swagger spec #6653

ctaggart · 2019-07-17T09:38:42Z

This is the a initial publish of our preview of our swagger spec. It matches the currently deployed service. The CLI published yesterday at https://github.com/virtustream/azure-vmware-virtustream-cli-extension/releases/tag/0.2.0 used this spec.

.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-07-17T09:39:12Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout ee9825c58bb9b0677a89122c6e28d1e41ab69fe6
  stderr: 'fatal: reference is not a tree: ee9825c58bb9b0677a89122c6e28d1e41ab69fe6'

AutorestCI · 2019-07-17T09:39:31Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout ee9825c58bb9b0677a89122c6e28d1e41ab69fe6
  stderr: 'fatal: reference is not a tree: ee9825c58bb9b0677a89122c6e28d1e41ab69fe6'

AutorestCI · 2019-07-17T09:39:53Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

azuresdkci · 2019-07-17T09:40:33Z

Can one of the admins verify this patch?

ctaggart · 2019-07-17T12:33:43Z

I ran the latest autorest validator and I just fixed one of the seven errors so far. The remaining six are:

ERROR (PutGetPatchResponseSchema/R3007/ARMViolation): /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.VMwareVirtustream/privateClouds/{privateCloudName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.
- file:///src/vmwarevirtustream.json:167:4 ($.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.VMwareVirtustream/privateClouds/{privateCloudName}"])
ERROR (OperationsAPIImplementation/R3023/ARMViolation): Operations API must be implemented for '/providers/Microsoft.VMwareVirtustream/operations'.
- file:///src/vmwarevirtustream.json:78:2 ($.paths)
ERROR (XmsResourceInPutResponse/R2062/ARMViolation): The 200 response model for an ARM PUT operation must have x-ms-azure-resource extension set to true in its hierarchy. Operation: 'PrivateCloud_Create' Model: 'AzureClusterResponse'.
- file:///src/vmwarevirtustream.json:201:6 ($.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.VMwareVirtustream/privateClouds/{privateCloudName}"].put)
ERROR (XmsResourceInPutResponse/R2062/ARMViolation): The 200 response model for an ARM PUT operation must have x-ms-azure-resource extension set to true in its hierarchy. Operation: 'PrivateCloud_Create' Model: 'AzureClusterResponse'.
- file:///src/vmwarevirtustream.json:201:6 ($.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.VMwareVirtustream/privateClouds/{privateCloudName}"].put)
ERROR (XmsExamplesRequired/D5001/Documentation): Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
- file:///src/vmwarevirtustream.json:78:2 ($.paths)
ERROR (RequiredPropertiesMissingInResourceModel/R2020/ARMViolation): Model definition 'AzureClusterResponse' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
- file:///src/vmwarevirtustream.json:1386:4 ($.definitions.AzureClusterResponse)

openapi-sdkautomation · 2019-07-17T16:19:58Z

In Testing, Please Ignore

[Logs] (Generated from 285c483, Iteration 33)

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-vmwarevirtustream [Logs]

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

No packages generated.

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

No packages generated.

jhendrixMSFT · 2019-07-17T16:21:27Z

The README.md file is missing, please see here for an example. If you want to automatically build SDKs for this swagger please also include the README.*.md files for the various languages and I will tag the language owners to review.

ctaggart · 2019-07-17T16:21:41Z

Errors from the autorest validator have all been fixed except for providing x-ms-examples. Can we add those for the next preview?

jhendrixMSFT

Add missing README.md file.

jhendrixMSFT · 2019-07-17T16:23:13Z

Please also provide examples for each operation as they are used for validation and doc generation. See this for an example.

jhendrixMSFT · 2019-07-17T16:27:06Z

Looks like our comments crossed regarding examples. For new swaggers, it's a requirement that they include examples before merging, unless this is a time-critical release.

KrisBash · 2019-07-17T17:07:05Z

@ctaggart Has this spec undergone ARM review (in meeting or a prior swagger version)?

ctaggart · 2019-07-17T17:29:35Z

The README.md file is missing, please see here for an example. If you want to automatically build SDKs for this swagger please also include the README.*.md files for the various languages and I will tag the language owners to review.

@jhendrixMSFT, I added a readme.md. We use TypeScript, Python, and .NET, so those are are initial targets.

ctaggart · 2019-07-17T17:56:24Z

Has this spec undergone ARM review (in meeting or a prior swagger version)?

@KrisBash, it has had some review. Shoot me an email and I'll give you more details. My email is on these commits. It is the standard [email protected].

Please also provide examples for each operation as they are used for validation and doc generation. See this for an example.

Okay, I'll begin putting that together tomorrow.

daviwil · 2019-07-26T18:02:26Z

@OpenAPIBot sdkautomation rebuild

ctaggart · 2019-07-26T18:06:34Z

@antmarti-microsoft, thanks for the ARM review. I've made all of the swagger updates that I can make and still remain compatible with the version 2016-09-01-preview that is deployed.

There are several changes that you would like to see that would need to go into a new version of the API. May be we can call it 2019-08-09-preview, which is two weeks out. You've requested changes to these operations:

PrivateClouds_List
Clusters_List

They need to be pageable.

PrivateClouds_GetAdminCredentials

https://github.com/Azure/azure-rest-api-specs/pull/6653/files/7aafcf289d83ba332baab86553f52b6c272ac65b#r307617878

The standard for getting credentials is a POST action prefixed with "list" - i.e. "listAdminCredentials". This means this functionality can be utilized during template deployments (for example if you wanted to create a private cloud, fetch credentials, and then pass the credentials to some other resource like a keyvault).

PrivateClouds_AddIdentitySource
PrivateClouds_DeleteIdentitySource
PrivateClouds_AddAuthorization
PrivateClouds_DeleteAuthorization

https://github.com/Azure/azure-rest-api-specs/pull/6653/files/7aafcf289d83ba332baab86553f52b6c272ac65b#r307618510

Standard guidance would be to either implement this as a POST action directly on the private cloud resource (i.e. /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.VMwareVirtustream/privateClouds/{privateCloudName}/addAuthorization where the body includes the {authorizationName}), or to implement "authorizations" as an actual proxy resource and support CRUD on it - ARM is quite specific about how it interprets key-value pairs in resource URIs.

https://github.com/Azure/azure-rest-api-specs/pull/6653/files/7aafcf289d83ba332baab86553f52b6c272ac65b#r307618654

Same as above comment - standard guidance would be to either implement this as a POST action directly on the private cloud resource (i.e. /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.VMwareVirtustream/privateClouds/{privateCloudName}/deleteAuthorization where the body includes the {authorizationName}), or to implement "authorizations" as an actual proxy resource and support CRUD on it.

I'm hoping we can get this merged, which matches the API currently deployed, then address those changes in version 2019-08-09-preview.

ctaggart · 2019-07-30T13:50:57Z

@antmarti-microsoft What do you think? Can we get this merged?

ravbhatnagar

@ctaggart - few comments. Please take a look.

...source-manager/Microsoft.VMwareVirtustream/preview/2016-09-01-preview/vmwarevirtustream.json

ravbhatnagar · 2019-07-31T18:25:40Z

...source-manager/Microsoft.VMwareVirtustream/preview/2016-09-01-preview/vmwarevirtustream.json

+              "$ref": "#/definitions/PrivateCloudResponse"
+            }
+          },
+          "202": {


Just wanted to make sure you want to use the 202 + location header pattern for the long running operations by choice. The pattern we recommend is 201 + non-terminal provisioning State + Azure Async operation header. Details here - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/Addendum.md#creating-or-updating-resources

We'll use 201 and follow the recommended pattern for the recommended pattern for the next API version.

#6878 contains this change in the new API version.

ravbhatnagar · 2019-07-31T18:26:41Z

...source-manager/Microsoft.VMwareVirtustream/preview/2016-09-01-preview/vmwarevirtustream.json

+        ],
+        "responses": {
+          "200": {
+            "description": "successful operation",


It MUST be wrapped in a "value" array even if paging is not supported in v1.

...source-manager/Microsoft.VMwareVirtustream/preview/2016-09-01-preview/vmwarevirtustream.json

ravbhatnagar · 2019-07-31T18:37:51Z

...source-manager/Microsoft.VMwareVirtustream/preview/2016-09-01-preview/vmwarevirtustream.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.VMwareVirtustream/privateClouds/{privateCloudName}/deleteAuthorization/{authorizationName}": {


This API is updating the property on the privateClouds resource. It should be enabled via a PATCH on privateClouds rather than modeling it as a POST action.

...source-manager/Microsoft.VMwareVirtustream/preview/2016-09-01-preview/vmwarevirtustream.json

ctaggart · 2019-08-05T18:43:09Z

This API spec matches the deployed version. Any remaining ARM review issues are breaking changes and will be in a version 2019-08-09-preview due out soon. Are you able to merge this pull request as is? If not, what else is needed?

anthony-c-martin · 2019-08-09T16:22:12Z

...Microsoft.VMwareVirtustream/preview/2016-09-01-preview/examples/Clusters_CreateOrUpdate.json

+{
+  "parameters": {
+    "api-version": "2016-09-01-preview",
+    "subscriptionId": "{subscription-id}",


[nit] find+replace {subscription-id} in these examples with something that resembles real data (random guid)

anthony-c-martin · 2019-08-09T16:24:23Z

...source-manager/Microsoft.VMwareVirtustream/preview/2016-09-01-preview/vmwarevirtustream.json

+        ],
+        "responses": {
+          "200": {
+            "description": "successful operation",


@ctaggart are you planning on addressing this comment (re wrapping in a "value")?

anthony-c-martin · 2019-08-09T16:56:02Z

...source-manager/Microsoft.VMwareVirtustream/preview/2016-09-01-preview/vmwarevirtustream.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.VMwareVirtustream/privateClouds/{privateCloudName}/addAuthorization/{authorizationName}": {


As per these comments ^ the URL shouldn't include the /{authorizationName} at the end, or ARM will misinterpret this action. https://armwiki.azurewebsites.net/faq/armbasics.html has some information.

anthony-c-martin · 2019-08-09T16:56:31Z

...source-manager/Microsoft.VMwareVirtustream/preview/2016-09-01-preview/vmwarevirtustream.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.VMwareVirtustream/privateClouds/{privateCloudName}/deleteAuthorization/{authorizationName}": {


Was a decision reached on PATCH vs POST?

ctaggart · 2019-08-12T16:33:47Z

This API version did not pass ARM review. @anthony-c-martin, please review #6878 instead, which is a new version of the API to address all issues brought up in the ARM review so far.

* swagger spec validation * test latest spec from Azure/azure-rest-api-specs#6653 * update to latest spec in progress * remove operation status and results * easier changes from ARM review * private cloud list will be paged * added default ApiError * remove cluster location * remove privatecloud update * update to 2019-08-09-preview API * no longer gen'd * additional api changes

add 2016-09-01-preview spec in json format

1f86d55

azuresdkci assigned jhendrixMSFT Jul 17, 2019

azuresdkci requested a review from jhendrixMSFT July 17, 2019 09:40

ctaggart mentioned this pull request Jul 17, 2019

swagger spec validation Azure/az-vmware-cli#2

Closed

ctaggart added 2 commits July 17, 2019 21:19

2 space indentation

1873d6e

add securityDefinitions and other boilerplate

fbaf4f1

ctaggart added 3 commits July 17, 2019 23:06

marked x-ms-azure-resource

c20064c

resources require readonly id, name, and type

50bf2e8

add operations

5b1392f

ctaggart added a commit to Azure/az-vmware-cli that referenced this pull request Jul 17, 2019

test latest spec from Azure/azure-rest-api-specs#6653

fdea390

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 17, 2019

jhendrixMSFT requested changes Jul 17, 2019

View reviewed changes

KrisBash added the ARMReviewInProgress label Jul 17, 2019

add readme

b4aa717

AutorestCI mentioned this pull request Jul 17, 2019

[AutoPR vmwarevirtustream/resource-manager] initial VMware by Virtustream preview swagger spec Azure/azure-sdk-for-python#6385

Closed

ctaggart mentioned this pull request Jul 18, 2019

unhelpful error when referenced file not found or empty Azure/oav#444

Closed

stub out operation examples

2be873d

anthony-c-martin added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 26, 2019

easier changes from ARM review

cbc03c1

openapi-sdkautomation bot mentioned this pull request Jul 26, 2019

[AutoPR @azure/arm-vmwarevirtustream] initial VMware by Virtustream preview swagger spec Azure/azure-sdk-for-js#4454

Closed

ctaggart added 7 commits July 26, 2019 23:45

pageable APIs

5787f3e

"nextLinkName": null

8dc9ba5

nextLinkName null for PrivateClouds_List

5831bf4

"type": "array" is required in pageable response

aeacc87

added default ApiError

97efa9a

remove cluster location

7d086ca

remove PrivateClouds_Update

8915756

ravbhatnagar reviewed Jul 31, 2019

View reviewed changes

ctaggart added 5 commits August 2, 2019 21:30

min and max clusterSize

c5057d6

nextLink

971ded9

add 200s for delete

86b72b5

resolve custom-words.txt conflict again

6264625

200 response code in examples for delete

be66669

ctaggart mentioned this pull request Aug 6, 2019

VMware by Virtustream API 2019-08-09-preview #6878

Merged

5 tasks

ctaggart added 4 commits August 6, 2019 21:56

ExpressRouteAuthorization readOnly props

7fe91b1

version 0.1.0

8cae242

custom-words.txt never ending merge conflict

4fe9570

alphabetize custom word additions

285c483

anthony-c-martin requested changes Aug 9, 2019

View reviewed changes

ctaggart closed this Aug 12, 2019

ctaggart deleted the 2016-09-01-preview branch February 4, 2020 19:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

initial VMware by Virtustream preview swagger spec #6653

initial VMware by Virtustream preview swagger spec #6653

ctaggart commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 17, 2019 •

edited

Loading

azuresdkci commented Jul 17, 2019

ctaggart commented Jul 17, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2019 •

edited

Loading

jhendrixMSFT commented Jul 17, 2019

ctaggart commented Jul 17, 2019

jhendrixMSFT left a comment

jhendrixMSFT commented Jul 17, 2019

jhendrixMSFT commented Jul 17, 2019

KrisBash commented Jul 17, 2019

ctaggart commented Jul 17, 2019

ctaggart commented Jul 17, 2019 •

edited

Loading

daviwil commented Jul 26, 2019

ctaggart commented Jul 26, 2019 •

edited

Loading

ctaggart commented Jul 30, 2019

ravbhatnagar left a comment

ravbhatnagar Jul 31, 2019

ctaggart Aug 5, 2019

ctaggart Aug 6, 2019

ravbhatnagar Jul 31, 2019

ravbhatnagar Jul 31, 2019

ctaggart commented Aug 5, 2019 •

edited

Loading

anthony-c-martin Aug 9, 2019

anthony-c-martin Aug 9, 2019

anthony-c-martin Aug 9, 2019

anthony-c-martin Aug 9, 2019

ctaggart commented Aug 12, 2019

initial VMware by Virtustream preview swagger spec #6653

initial VMware by Virtustream preview swagger spec #6653

Conversation

ctaggart commented Jul 17, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Jul 17, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jul 17, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 17, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Jul 17, 2019

ctaggart commented Jul 17, 2019 • edited Loading

openapi-sdkautomation bot commented Jul 17, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 285c483, Iteration 33)

jhendrixMSFT commented Jul 17, 2019

ctaggart commented Jul 17, 2019

jhendrixMSFT left a comment

Choose a reason for hiding this comment

jhendrixMSFT commented Jul 17, 2019

jhendrixMSFT commented Jul 17, 2019

KrisBash commented Jul 17, 2019

ctaggart commented Jul 17, 2019

ctaggart commented Jul 17, 2019 • edited Loading

daviwil commented Jul 26, 2019

ctaggart commented Jul 26, 2019 • edited Loading

ctaggart commented Jul 30, 2019

ravbhatnagar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ctaggart commented Aug 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ctaggart commented Aug 12, 2019

ctaggart commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 17, 2019 •

edited

Loading

ctaggart commented Jul 17, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2019 •

edited

Loading

ctaggart commented Jul 17, 2019 •

edited

Loading

ctaggart commented Jul 26, 2019 •

edited

Loading

ctaggart commented Aug 5, 2019 •

edited

Loading