[HDInsight] Support kafka rest proxy feature #7844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-goA PR has been created for you: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
aim-for-better
force-pushed
the
SupportKafakaRestProxy
branch
3 times, most recently
from
80dcc3b to
82ab7ec
Compare
|
please fix CI failure for |
aim-for-better
force-pushed
the
SupportKafakaRestProxy
branch
2 times, most recently
from
65566c0 to
9cf684b
Compare
|
npm install; npm run prettier-fix |
fixed. But there is a PrettierCheck failed. Could you please help us with this issue? |
PrettierCheck is not mandatory. But if you would like to fix it, please follow https://aka.ms/AA6h31t. |
| @@ -2,7 +2,7 @@ | |||
| "parameters": { | |||
| "clusterName": "cluster1", | |||
| "resourceGroupName": "rg1", | |||
| "api-version": "2018-06-01-preview", | |||
| "api-version": "2015-03-01-preview", | |||
There was a problem hiding this comment.
This change doesn't look right.
And I think the files for 2018-06-01-preview should be under preview folder, not stable.
There was a problem hiding this comment.
This change doesn't look right.
And I think the files for2018-06-01-previewshould be under preview folder, not stable.
api version is fixed.
And for why the file 2018-06-01-preview under stable folder, this is a history problem.
This is intentional. It’s a little confusing, but per rule #5 here, whether the swagger spec is in the preview or stable folder “is not a direct analog for whether or not an API Version has the ‘-preview’ suffix or not. SDKs that are generated from 'preview' folder items should indicate to their customers in the most idiomatic way that breaking changes may still be coming.”
Basically the short version is that HDInsight is a GA service that still has an API with a -preview tag. Somebody made the decision several years ago to release stable versions of Hydra/Hyak SDKs for .NET, JavaScript, etc. that consumed this the -preview API. We are now releasing stable swagger-based SDKs so we can at least finally deprecate the Hydra/Hyak SDKs. As a result, we are making a commitment that we will not make breaking changes to this swagger spec version so we can GA some swagger-based SDKs.
aim-for-better
force-pushed
the
SupportKafakaRestProxy
branch
from
9cf684b to
b9658d3
Compare
fengzhou-msft
approved these changes
Dec 2, 2019
|
@fengzhou-msft When this PR can be merged? |
fengzhou-msft
added
the
WaitForARMFeedback
2. Add response body to preview example 3. Add response body to stable example 4. fix prettiercheck
aim-for-better
force-pushed
the
SupportKafakaRestProxy
branch
from
b9658d3 to
6ff955b
Compare
|
Have fixed prettier check |
KrisBash
approved these changes
Dec 4, 2019
| "gateway": { | ||
| "restAuthCredential.isEnabled": true, | ||
| "restAuthCredential.username": "admin", | ||
| "restAuthCredential.password": "**********" |
There was a problem hiding this comment.
While this is an example, please ensure that secrets (Password) are never returned in a GET, as suggested here
There was a problem hiding this comment.
While this is an example, please ensure that secrets (Password) are never returned in a GET, as suggested here
Hi @KrisBash Thanks for your comment. We have user role to control this.
| @@ -553,6 +556,28 @@ | |||
| } | |||
| } | |||
| }, | |||
| "ClientGroupInfo": { | |||
There was a problem hiding this comment.
It's strongly preferred to add new configurable properties in a new API version. The issue is when a user updates the new properties, and another user does a GET->PUT with an older SDK. The new properties would be omitted from the request body from the downlevel SDK
There was a problem hiding this comment.
It's strongly preferred to add new configurable properties in a new API version. The issue is when a user updates the new properties, and another user does a GET->PUT with an older SDK. The new properties would be omitted from the request body from the downlevel SDK
Thanks for your comment. This new properties is not mandatory. And I agree with your opinion. But now we don't have enough time to do this. Adding new api version also needs rp's support.
KrisBash
added
ARMSignedOff
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
This was referenced Dec 4, 2019
TalluriAnusha
pushed a commit
to AsrOneSdk/azure-rest-api-specs
that referenced
this pull request
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDInsight
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.