-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update description for grace period and remove property from Automati… #7928
Update description for grace period and remove property from Automati… #7928
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving - this feature already requires whitelisting, so it's essentially in private preview and won't be a generally breaking change.
Azure Pipelines successfully started running 1 pipeline(s). |
3 similar comments
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
Please take a look at the Net SDK CI error and fix it. |
Hi @fengzhou-msft , So the failures occurred due to a test failure looking at the logs: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>VMScaleSetTests/VMScaleSetScenarioTests.cs(300,29): error CS0117: 'AutomaticRepairsPolicy' does not contain a definition for 'MaxInstanceRepairsPercent' [/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj] The test update is in this SDK PR which needs approval: https://github.com/Azure/azure-sdk-for-net/pull/9090/files |
Hi Feng,
So I have SDK PR open which would fix the test that’s causing the SDK error.
This is the error:
2019-12-10T00:01:12.032Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>VMScaleSetTests/VMScaleSetScenarioTests.cs(300,29): error CS0117: 'AutomaticRepairsPolicy' does not contain a definition for 'MaxInstanceRepairsPercent' [/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj]
2019-12-10T00:01:12.037Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>VMScaleSetTests/VMScaleSetScenarioTests.cs(317,77): error CS1061: 'AutomaticRepairsPolicy' does not contain a definition for 'MaxInstanceRepairsPercent' and no accessible extension method 'MaxInstanceRepairsPercent' accepting a first argument of type 'AutomaticRepairsPolicy' could be found (are you missing a using directive or an assembly reference?) [/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj]
2019-12-10T00:01:12.038Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>VMScaleSetTests/VMScaleSetTestsBase.cs(559,112): error CS1061: 'AutomaticRepairsPolicy' does not contain a definition for 'MaxInstanceRepairsPercent' and no accessible extension method 'MaxInstanceRepairsPercent' accepting a first argument of type 'AutomaticRepairsPolicy' could be found (are you missing a using directive or an assembly reference?) [/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj]
2019-12-10T00:01:12.039Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>VMScaleSetTests/VMScaleSetTestsBase.cs(560,67): error CS1061: 'AutomaticRepairsPolicy' does not contain a definition for 'MaxInstanceRepairsPercent' and no accessible extension method 'MaxInstanceRepairsPercent' accepting a first argument of type 'AutomaticRepairsPolicy' could be found (are you missing a using directive or an assembly reference?) [/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj]
2019-12-10T00:01:12.042Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>Done Building Project "/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj" (Build target(s)) -- FAILED.
2019-12-10T00:01:12.043Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>Done Building Project "/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj" (default targets) -- FAILED.
This is the PR to address this error by modifying the test which is failing: ‘https://github.com/Azure/azure-sdk-for-net/pull/9090/files
Should I checkin the SDK PR first and then this PR?
Thanks,
Harini Pandari
From: Feng Zhou <[email protected]>
Sent: Wednesday, December 11, 2019 8:21 PM
To: Azure/azure-rest-api-specs <[email protected]>
Cc: Harini Pandari <[email protected]>; Author <[email protected]>
Subject: Re: [Azure/azure-rest-api-specs] Update description for grace period and remove property from Automati… (#7928)
Please take a look at the Net SDK CI error and fix it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F7928%3Femail_source%3Dnotifications%26email_token%3DAKXW7X7L2DPR5ZLCUW3TQK3QYG32RA5CNFSM4JYT24BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGVNFHY%23issuecomment-564843167&data=02%7C01%7CHarini.Pandari%40microsoft.com%7C7557c34b39da42fc5cfc08d77ebaafce%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637117212601268519&sdata=BkMBhPjM0w7Ad9AFqEEDeGLlhHMv8D7s97YLahHFPM0%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKXW7X6CLV4A2BZEMMO3KQ3QYG32RANCNFSM4JYT24BA&data=02%7C01%7CHarini.Pandari%40microsoft.com%7C7557c34b39da42fc5cfc08d77ebaafce%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637117212601278516&sdata=JIhWz6g3m%2FJG%2FqS9WQi1ZNp2QtpA7UOJQInB3krRoek%3D&reserved=0>.
|
Hi Feng,
So apparently SDK test is not required to check-in swagger changes. The SDK test fix PR is already in progress.
Could you approve this swagger PR if you don’t see any other issues.
Since this is a chicken and an egg problem. This PR introduces a breaking change and therefore causes test to fail. However the fix is in SDK PR which can only be checked in if this PR gets merged to master.
Thanks,
Harini Pandari
From: Harini Pandari
Sent: Thursday, December 12, 2019 10:43 AM
To: 'Azure/azure-rest-api-specs' <[email protected]>; Azure/azure-rest-api-specs <[email protected]>
Cc: Author <[email protected]>
Subject: RE: [Azure/azure-rest-api-specs] Update description for grace period and remove property from Automati… (#7928)
Hi Feng,
So I have SDK PR open which would fix the test that’s causing the SDK error.
This is the error:
2019-12-10T00:01:12.032Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>VMScaleSetTests/VMScaleSetScenarioTests.cs(300,29): error CS0117: 'AutomaticRepairsPolicy' does not contain a definition for 'MaxInstanceRepairsPercent' [/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj]
2019-12-10T00:01:12.037Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>VMScaleSetTests/VMScaleSetScenarioTests.cs(317,77): error CS1061: 'AutomaticRepairsPolicy' does not contain a definition for 'MaxInstanceRepairsPercent' and no accessible extension method 'MaxInstanceRepairsPercent' accepting a first argument of type 'AutomaticRepairsPolicy' could be found (are you missing a using directive or an assembly reference?) [/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj]
2019-12-10T00:01:12.038Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>VMScaleSetTests/VMScaleSetTestsBase.cs(559,112): error CS1061: 'AutomaticRepairsPolicy' does not contain a definition for 'MaxInstanceRepairsPercent' and no accessible extension method 'MaxInstanceRepairsPercent' accepting a first argument of type 'AutomaticRepairsPolicy' could be found (are you missing a using directive or an assembly reference?) [/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj]
2019-12-10T00:01:12.039Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>VMScaleSetTests/VMScaleSetTestsBase.cs(560,67): error CS1061: 'AutomaticRepairsPolicy' does not contain a definition for 'MaxInstanceRepairsPercent' and no accessible extension method 'MaxInstanceRepairsPercent' accepting a first argument of type 'AutomaticRepairsPolicy' could be found (are you missing a using directive or an assembly reference?) [/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj]
2019-12-10T00:01:12.042Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>Done Building Project "/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj" (Build target(s)) -- FAILED.
2019-12-10T00:01:12.043Z: [Azure/azure-sdk-for-net][Microsoft.Azure.Management.Compute][MSBuild] 3>Done Building Project "/z/work/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/tests/Microsoft.Azure.Management.Compute.Tests.csproj" (default targets) -- FAILED.
This is the PR to address this error by modifying the test which is failing: ‘https://github.com/Azure/azure-sdk-for-net/pull/9090/files
Should I checkin the SDK PR first and then this PR?
Thanks,
Harini Pandari
From: Feng Zhou <[email protected]<mailto:[email protected]>>
Sent: Wednesday, December 11, 2019 8:21 PM
To: Azure/azure-rest-api-specs <[email protected]<mailto:[email protected]>>
Cc: Harini Pandari <[email protected]<mailto:[email protected]>>; Author <[email protected]<mailto:[email protected]>>
Subject: Re: [Azure/azure-rest-api-specs] Update description for grace period and remove property from Automati… (#7928)
Please take a look at the Net SDK CI error and fix it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F7928%3Femail_source%3Dnotifications%26email_token%3DAKXW7X7L2DPR5ZLCUW3TQK3QYG32RA5CNFSM4JYT24BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGVNFHY%23issuecomment-564843167&data=02%7C01%7CHarini.Pandari%40microsoft.com%7C7557c34b39da42fc5cfc08d77ebaafce%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637117212601268519&sdata=BkMBhPjM0w7Ad9AFqEEDeGLlhHMv8D7s97YLahHFPM0%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKXW7X6CLV4A2BZEMMO3KQ3QYG32RANCNFSM4JYT24BA&data=02%7C01%7CHarini.Pandari%40microsoft.com%7C7557c34b39da42fc5cfc08d77ebaafce%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637117212601278516&sdata=JIhWz6g3m%2FJG%2FqS9WQi1ZNp2QtpA7UOJQInB3krRoek%3D&reserved=0>.
|
The PR to fix Net SDK CI error has been submitted. |
…c repairs policy
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.