Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding BillingProfile Status, Reason, SpendingLimit and accountType. #8202

Merged
merged 6 commits into from
Jan 25, 2020
Merged

Adding BillingProfile Status, Reason, SpendingLimit and accountType. #8202

merged 6 commits into from
Jan 25, 2020

Conversation

asarkar84
Copy link
Contributor

@asarkar84 asarkar84 commented Jan 21, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@asarkar84 asarkar84 requested a review from wilcobmsft as a code owner January 21, 2020 20:46
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@asarkar84
Fixed the issues reported by Prettier
efd891d 
Fixed the issues reported by Prettier
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 22, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@yungezz
Copy link
Member

yungezz commented Jan 22, 2020 •
edited
Loading

/azp run automation - sdk

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 22, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2004b8f with merge commit 379b5f1. SDK Automation 13.0.17.20191226.1
  • ️✔️azure-mgmt-billing [Logs]  [Release SDK Changes] 
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 22, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 22, 2020 •
edited
Loading

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2004b8f with merge commit 379b5f1. SDK Automation 13.0.17.20191226.1
  • ️✔️sdk/billing/mgmt-v2017_02_27_preview [Logs]  [Release SDK Changes]
  • ️✔️sdk/billing/mgmt-v2017_04_24_preview [Logs]  [Release SDK Changes]
  • ️✔️sdk/billing/mgmt-v2018_03_01_preview [Logs]  [Release SDK Changes]
  • ⚠️sdk/billing/mgmt-v2018_11_01_preview [Logs]  [Release SDK Changes] 
      [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/billing/mgmt-v2019_10_01_preview [Logs]  [Release SDK Changes] 
        [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jan 22, 2020 •
      edited
      Loading

      azure-sdk-for-go - Release

      ️✔️ succeeded [Logs] [Expand Details]

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jan 22, 2020 •
      edited
      Loading

      azure-sdk-for-js - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 2004b8f with merge commit 379b5f1. SDK Automation 13.0.17.20191226.1
      • ️✔️@azure/arm-billing [Logs]  [Release SDK Changes] 
        [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/billingManagementClient.js → ./dist/arm-billing.js...
[npmPack] created ./dist/arm-billing.js in 713ms

      This was referenced Jan 22, 2020
      Closed
      Closed
      Closed
      Closed
      Closed
      Closed
      Closed
      Closed
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      2 similar comments
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @asarkar84
      Corrected the property name from customerType to acountType. There is…
      0fbd94d 
      … no such property called customerType in the API response.

Corrected the property name from customerType to acountType. There is no such property called customerType in the API response.
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @asarkar84 asarkar84 changed the title Adding BillingProfile Status, Reason and SpendingLimit Adding BillingProfile Status, Reason and SpendingLimit. Correcting the property name to accountType since there is no customerType property in the actual response. Jan 23, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @asarkar84 asarkar84 changed the title Adding BillingProfile Status, Reason and SpendingLimit. Correcting the property name to accountType since there is no customerType property in the actual response. Adding BillingProfile Status, Reason and SpendingLimit. Correcting the property name to accountType since there was never a property called customerType existed in the actual response. Jan 23, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @majastrz majastrz added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 23, 2020
      majastrz
      majastrz requested changes Jan 23, 2020
      View reviewed changes
      Copy link
      Member

      @majastrz majastrz left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      The change introduces a breaking change. Please take a look at my comment.

      @asarkar84
      Added AccountType
      2004b8f 
      Added AccountType
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @asarkar84
      Copy link
      Contributor Author

      @majastrz Please take a look. I have added the customerType property back. Will remove it in next version.

      @asarkar84 asarkar84 changed the title Adding BillingProfile Status, Reason and SpendingLimit. Correcting the property name to accountType since there was never a property called customerType existed in the actual response. Adding BillingProfile Status, Reason, SpendingLimit and accountType. Jan 23, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 24, 2020
      majastrz
      majastrz approved these changes Jan 24, 2020
      View reviewed changes
      Copy link
      Member

      @majastrz majastrz left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      Signed off from ARM side.

      @asarkar84
      Copy link
      Contributor Author

      @yungezz Please merge the PR.

      @yungezz yungezz merged commit 379b5f1 into Azure:master Jan 25, 2020
      ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
      @asarkar84 @ssripadham
      Adding BillingProfile Status, Reason, SpendingLimit and accountType. (A…
      dab2dcc 
      …zure#8202)
      00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
      @asarkar84 @00Kai0
      Adding BillingProfile Status, Reason, SpendingLimit and accountType. (A…
      ebd37a6 
      …zure#8202)
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @majastrz majastrz majastrz approved these changes

      @yungezz yungezz yungezz approved these changes

      @wilcobmsft wilcobmsft Awaiting requested review from wilcobmsft wilcobmsft is a code owner

      Assignees

      @yungezz yungezz

      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      3 participants
      @asarkar84 @yungezz @majastrz