Skip to content

Commit

Permalink
Final merge to main for Key Vault 7.3 (#3783)
Browse files Browse the repository at this point in the history
* Update Certificates service version to 7.3 (#3538)

* one commit to rule them all

* update to 7.3 version and comment

* support 7.2

* Update service version for keyvault Keys to 7.3 (#3539)

* one commit to rule them all

* updated to version 7.3 and updated tests and recordings.

* 7.2

* Update service version for keyvault Secrets to 7.3 (#3540)

* one commit to rule them all

* Updated service version to 7.3

* support v7.2

* typo

* Update deps to latest version of core and identity (#3541)

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* bump keys version to 7.3

* Revert "bump keys version to 7.3"

This reverts commit e348e96.

* update the versions for the core and identity deps for the keyvault APIs. needed for some api implementations.

* removed identity dep

* put back ident

* remove ident from folder

* 1.4.0

* update vcpkg commit

* put back ident

* remove again

* update vcpkg commit

* PR comment

* vcpkg commit min for azure core 1.5

* increase timeout

* Key vault work - RNG and rotation policy (#3560)

* one commit to rule them all

* work in progress

* tests for serialize deserialize

* typos

* to lower

* enable test

* guard live

* typos, types, and many more

* maybe now ? please ...

* PR comments

* rotate API (#3602)

* Release key prep (#3597)

* step1

* part2

* code maybe

* working to create exportable with release policy

* still not working

* cleanup

* revert attestation change, fix crypto tests

* fix ut

* format and pedantic chars

* PR

* some UTs

* oops

* what can i do

* PR comments

* Release key API  (#3622)

* step1

* part2

* code maybe

* working to create exportable with release policy

* still not working

* Release Key Works now

* format

* qfe

* clean build issues

* build fixes

* PR comments

* cspell

* rework the test to use the source keys instead of jwk. needed to be restored for live tests

* update location

* FIX  hsm test (#3630)

* tests pass

* oops

* update hsm path

* clang

* update test resources

* try try again

* try again

* update variable in azure core

* template worx

* clang

* try pipeline1

* see now

* try try again

* darn json

* oh boy

* oh boy

* rwerwerw

* jioijhjui

* maybe now ?

* maybe now ?

* increase timeout and fix ps script

* keyvault permissions

* rebalance regions

* ssssss

* [p]ppi

* try this

* fsdfsdfsd

* maybe now

* test again

* maybe

* maybe

* maybe 2

* try again

* ssssss

* uyufyut

* maybe now ?

* try again

* t/f/1/0

* cleanup

* maybe now

* edeployment output

* oook

* let's see the envs

* fix 2 tests

* another one

* try try again

* oops

* powershell error

* ps again

* i hate this so much right now

* try try again

* try again

* dsaas

* rewrwr

* erwrw

* windows?

* libcurl ?

* ???

* retry

* retyr message , api version

* again

* ok maybe

* dssds

* final updates

* missing line

* Update docs (#3678)

* begining

* update readmes

* Update sdk/keyvault/azure-security-keyvault-certificates/CHANGELOG.md

Co-authored-by: Anton Kolesnyk <[email protected]>

* Update sdk/keyvault/azure-security-keyvault-keys/CHANGELOG.md

Co-authored-by: Anton Kolesnyk <[email protected]>

* Update sdk/keyvault/azure-security-keyvault-keys/README.md

Co-authored-by: Anton Kolesnyk <[email protected]>

* Update sdk/keyvault/azure-security-keyvault-secrets/CHANGELOG.md

Co-authored-by: Anton Kolesnyk <[email protected]>

Co-authored-by: Anton Kolesnyk <[email protected]>

* Merge from main (#3760)

* one commit to rule them all

* Sync eng/common directory with azure-sdk-tools for PR 3000 (#3485)

* Sort by client, mgmt, track2, track1

* sort by the type

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Wes Haggard <[email protected]>

* fix the sorting

* Define the order of new and type

* address comments

* fix typo

* Address your comments

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update Generate-DocIndex.ps1

* Update Generate-DocIndex.ps1

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Wes Haggard <[email protected]>

Co-authored-by: sima-zhu <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>

* Support BaseName overrides in CI mode for New-TestResources.ps1 (#3559)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Do not pass Generated to -BaseName (#3562)

Co-authored-by: Heath Stewart <[email protected]>

* Sort by service name first (#3570)

Co-authored-by: sima-zhu <[email protected]>

* Initialize the suppression file. (#3569)

* Sync eng/common directory with azure-sdk-tools for PR 3169 (#3572)

* Use the batch version of ValidateDocsMsPackagesFn

* Use proper pipelining for GetPackageInfoJson function

Co-authored-by: Patrick Hallisey <[email protected]>

* [Tech Docs] Libcurl transport adapter (#3484)

* libcurl transport adapter

* updates

* Update LibcurlTransportAdapter.md

* Update LibcurlTransportAdapter.md

* Update doc/LibcurlTransportAdapter.md

Co-authored-by: Jeffrey Richter <[email protected]>

Co-authored-by: Jeffrey Richter <[email protected]>

* Skip azcopy download if it already exists (#3576)

Co-authored-by: Patrick Hallisey <[email protected]>

* Pin openssl to 1.1.1n (#3575)

* Pin openssl to 1.1.1n

* Updated vcpkg commit to one containing OpenSSL 1.1.1n

* Fixed version number in vcpkg.json

* Fix typo (#3583)

* update curl transport options to support ignore proxy from system (#3564)

* update curl transport options to support ignore proxy from system

* update changelog

* bug fix for cl

* update log level from Retry policy (#3586)

* update log level

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Ahson Khan <[email protected]>

Co-authored-by: Ahson Khan <[email protected]>

* Add batch protocol layer (#3580)

* Add batch protocol layer

* some small fixes on Storage cmakefiles (#3588)

* Migrate to matrix generator (#3553)

* Represent existing matrix in json
* Use new matrix
* Move to stage
* Cloud configuration
* MaxParallel
* DependsOn
* Quote CtestRegex
* Use template for cmake generate tests
* Template name mappings
* Formatting, parameters
* Remove duplicate bypass-local-dns.yml
* Enable Location override
* Add Location
* Add spelling words
* Use Ubuntu 20 where the name specifies Ubuntu 20
* Apply suggestions from code review

Co-authored-by: Ben Broderick Phillips <[email protected]>

* PR feedback
* fix storage sample
* Matrix documentation

Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Victor Vazquez <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 3212 (#3587)

* bump consumed version of test proxy. update scripting to target the fully cross-platform image tag name.
* update target version of the test-proxy to one that enforces http/1.1

Co-authored-by: scbedd <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 3238 (#3590)

* pin proxy version to one that properly sets listenoptions
* update targeted test-proxy docker repo. "testproxy" -> "test-proxy"

Co-authored-by: scbedd <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 3221 (#3591)

* Make docs.ms link relative link

* Update Update-DocsMsMetadata.ps1

* Update eng/common/scripts/Update-DocsMsMetadata.ps1

Co-authored-by: Daniel Jurek <[email protected]>

Co-authored-by: sima-zhu <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>

* Remove the daily branch before date (#3593)

Co-authored-by: sima-zhu <[email protected]>

* Add ClientCertificateCredential (#3578)

* Add ClientCertificateCredential

* Update unit test

* cspell

* Update Readme

* Cosmetic fixes

* Changelog to mention env cred update

* Fix warning

* cspell

* Tell CI to install openssl

* openssl for all Windows

* update dependency manifest

* Re-phrase changelog

* Clang warnings

* Clang warning

* Clang warning - 2

* Ubuntu18 warning

* Update sdk/identity/azure-identity/CHANGELOG.md

Co-authored-by: Victor Vazquez <[email protected]>

* PR feedback

Co-authored-by: Anton Kolesnyk <[email protected]>
Co-authored-by: Victor Vazquez <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 3250 (#3595)

* Change the direction of the commit date

* Log on right place

* remove auth

* fix typo

* Add auth token back

* add delete back

* Update eng/common/scripts/Delete-RemoteBranches.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update Delete-RemoteBranches.ps1

* Update Delete-RemoteBranches.ps1

* Update Delete-RemoteBranches.ps1

* Update Delete-RemoteBranches.ps1

* Update Delete-RemoteBranches.ps1

Co-authored-by: sima-zhu <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>

* Create a session handle once in the transport ctor and reuse it for all requests rather than creating a new one each time. (#3585)

* Reuse the same session handle for all requests rather than creating a new one each time.

* Move the session handle creation to the transport adapter ctor.

* Update changelog entry.

* Address PR feedback.

* Change CreateSessionHandle to return a local session handle

* Fix-up the changelog entry link for the curtransportoption bug fix (#3598)

* Remove extra period at ends of exception messages in winhttp transport (#3601)

* fix cmake in storage (#3604)

* Reword the curl proxy fix changelog entry. (#3606)

* Add Emma Zhu as code owner (#3605)

* Short circuit out of msdocs publish if no package locations are specified (#3607)

Co-authored-by: Patrick Hallisey <[email protected]>

* sdk/core: Reimplement Md5OpenSSL using EVP API (#3609)

The MD5_Init/Update/Final functions are deprecated in OpenSSL 3.0 and result in
a compile-time warning. Due to the default usage of -Werror during compilation,
these warnings are treated as errors and prevent the SDK from being built on
Ubuntu 22.04, which ships with OpenSSL by default. The deprecated APIs should
be replaced by the EVP APIs, which are already in use for the SHA family of
functions, and supported on all versions of OpenSSL.

* API Review Feedback for Attestation SDK (#3543)

* API Review Feedback for Attestation SDK

* Updated changelog to reflect API Review updates

* Remove version pin for OpenSSL (#3610)

* Remove version pin for OpenSSL

* Gratuitous change to trigger CI pipelines

* Update the version tool to the latest (#3616)

Co-authored-by: sima-zhu <[email protected]>

* Get rid of warnings in nullable.hpp (#3617)

* cl (#3613)

* Update pipeline-generator version (#3623)

Co-authored-by: Patrick Hallisey <[email protected]>

* Prepare Attestation SDK for May Release. (#3625)

* Prepare attestation for May release

* Removed some noise from changelog

* Increment package version after release of azure-core (#3624)

* Update CODEOWNERS (#3628)

* Fix identity samples running in CI (#3632)

* azure identity may 2022 release (#3615)

* Increment package version after release of azure-identity (#3637)

* Removed uwp-x86 from platform matrix. (#3629)

* Increment package version after release of azure-security-attestation (#3636)

* Update readme for -pre and -post TestResource scripts (#3645)

Co-authored-by: Christopher Scott <[email protected]>

* Fixed a bug where text of XML element cannot be empty. (#3643)

* String parsing improvements to service directory resource names (#3644)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Adding Acknowledgments (#3611)

* cl

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Ahson Khan <[email protected]>

* cspell

Co-authored-by: Ahson Khan <[email protected]>

* Add skip variable for remove test resources to support debugging (#3648)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Storage Blob Stg78 Features (#3650)

* Clean up target_include_directories() (#3641)

Co-authored-by: Anton Kolesnyk <[email protected]>

* Update all-inclusive headers, and CMakeFiles for including all headers (#3640)

* Remove (#3657)

oexcept specifier from Context::IsCancelled()

Co-authored-by: Anton Kolesnyk <[email protected]>

* Add Language product slug (#3665)

Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 3342 (#3664)

* Delete PR and branch which central PR is closed

* more logging changes

* resume the delete operations.

* Change the pr link directly

* fix the regex

* Refactor on regex name

* change the function to inline logic

* change typo

* delete on branch

* make changes on comments

* add commnets

* Update eng/common/scripts/Delete-RemoteBranches.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/scripts/Delete-RemoteBranches.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/scripts/Delete-RemoteBranches.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/scripts/Delete-RemoteBranches.ps1

Co-authored-by: Wes Haggard <[email protected]>

Co-authored-by: sima-zhu <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>

* Split out attestation client factory into separate class (#3654)

* Split out attestation client factory into separate class

* Updated readme; clang-format

* Final set of API review changes

* Replaced () constructors with {} constructors

* Initial implementation of OpenTelemetry APIs. (#3561)

* Start of tracing prototype

* Created initial implementation of azure-core-opentelemetry package

* New version of enabling MSVCRT Lib for static configs

* Attempt to add OpenTelemetry tests to build

* Take a dependency on OpenTelemetry version 1.3

* Added service API level tracing support

* API Review feedback

* storage unittest fix and improvement (#3667)

* main merge

* error

* Sync eng/common directory with azure-sdk-tools for PR 3362 (#3676)

* spell-check skippable by commit

* suceededOrFailed -> succeededOrFailed

Co-authored-by: scbedd <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 3378 (#3679)

* Create json package property parent directory

* Fix the issue in script

Co-authored-by: praveenkuttappan <[email protected]>

* Vcpkg sample (#3670)

* one commit to rule them all

* main merge

* error

* all smoke

* typo

* 120 minutes

* timeout param missing on job

* actual url

* Update samples/integration/vcpkg-all-smoke/src/main.cpp

Co-authored-by: Larry Osterman <[email protected]>

* actual creds

Co-authored-by: Larry Osterman <[email protected]>

* main merge

* error

* Complete the initial implementation of OpenTelemetry (#3677)

* Added telemetry support for HTTP pipeline elements

* Finish OpenTelemetry implementation

* clang-format and added doxygen comments

* Creadscan skips (#3671)

* one commit to rule them all

* main merge

* error

* add recordings for cred scan skipping

* certificates added

* remove dupe

* cspell

* Moved attestation factory back to static method on attestation class … (#3682)

* Moved attestation factory back to static method on attestation class and return a concrete type not a pointer

* Fixed factory in readme file

* main merge

* error

* main merge

* error

* iyuuyyu

* revert space

* OpenTelemetry API Review Feedback (#3687)

* OpenTelemetry API Review Feedback

* vcpkg version

* typos

* Attestation 1.0.0 GA Release (#3693)

* Prepare attestation for release

* removed references to RetrieveResponseValidationCollateral from docs

* Added C++ SDK team as owners of attestation SDK

* Added Ahmad from attestation team to attestation owners

* Removed dead API; switched attestation back to beta-3

* Disable detached head warnings on sparse checkout to commit (#3680)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Remove samples with docker.io (#3621)

* remove samples using docker.io

* removing docker files

* remove project

* Fix issue where matrix replace was not using imported display names (#3694)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Additional OpenTelemetry Feedback... (#3691)

* OpenTelemetry API Review Feedback

* Returns std::unique_ptr<DiagnosticTracingFactory instead of raw pointer

* Late breaking pull request feedback

* Renamed clientContext parameter to CreateSpan

* Renamed ContextAndSpanFactory to TracingContextFactory and CreateSpan to CreateTracingContext.

* Added ability to create instance with pointer (#3698)

* Added ability to create instance with pointer

* Pull request feedback

* Core 1.7.0-beta.1 Release (#3684)

Co-authored-by: Anton Kolesnyk <[email protected]>

* Increment package version after release of azure-core (#3699)

* Format vcpkg.json (#3701)

Co-authored-by: Anton Kolesnyk <[email protected]>

* Update README to list all the vcpkgs (#3704)

Co-authored-by: Anton Kolesnyk <[email protected]>

* Removed version>= fields for openssl in vcpkg.json files (#3705)

* Tab vcpkg publishing condition in to apply to the task (#3709)

* Storage June Release (#3686)

* Override live test location default to westus (#3696)

* Changelog updates for secrets and certificates (#3714)

* Changelog updates for secrets and certificates

* Update package versions

* Removed empty sections in changelog (#3718)

* Identity 1.3.0 Release (#3685)

Co-authored-by: Anton Kolesnyk <[email protected]>

* OpenTelemetry vcpkg fixes (#3716)

* OpenTelemetry vcpkg fixes

* Update ci.yml

* Drop version >= from project-level vcpkg

* find_package only supports numeric versions

* include(AzureBuildTargetForCI)

* Do not build as Windows/UWP DLL

* Docs and package dependencies

* Update condition

* Move condition down

* Move more under condition

* Rephrase condition

* Try hack for CI that won't affect vcpkg

Co-authored-by: Anton Kolesnyk <[email protected]>

* Increment package version after release of azure-identity (#3721)

* Increment version for storage releases (#3713)

* Increment package version after release of azure-storage-common

* Increment package version after release of azure-storage-blobs

* [EngSys] Get Vcpkg automatically (#3614)

* get vcpkg automatically

* Updated changelog (#3726)

* Increment package version after release of azure-core-tracing-opentelemetry (#3727)

* Increment package version after release of azure-security-attestation (#3717)

* Increment package version after release of azure-security-attestation (#3720)

* Enable Distributed Tracing for Attestation SDK client. (#3706)

* Implement tracing for Attestation and Template services

* Pipeline no longer requires service name if opting into distributed tracing; enable tracing in attestation service

* Generate user-agent header from request activity policy

* Added test to catch the redacted header regression

* Updated documentation to reflect API surface changes

* Make sample service an object library (#3728)

Co-authored-by: Anton Kolesnyk <[email protected]>

* Include �pi-version to default list of unredacted query params for logging (#3730)

Co-authored-by: Anton Kolesnyk <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 3433 (#3731)

* add condition

* divide line

Co-authored-by: Mariana Rios Flores <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 3267 (#3655)

* Use seperate scripts

* address comments.

* do compare and update

* save on the service level readme

* have the helper for reuse function

* remove mgmt table

* changes

* fix

* no return on error

* return if no contents

* Address comments

* change the table

* address wes comments.

* address wes comments.

* address more comments.

Co-authored-by: sima-zhu <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 3386 (#3733)

* Update the order of remarks and examples to align with docs.ms

* change all occurance

* Update class.tmpl.partial

Co-authored-by: sizhu <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>

* ensure conditions all work properly in the case of a previous error (#3732)

Co-authored-by: Scott Beddall <[email protected]>

* InputSanitizer: rename to HttpSanitizer, remove static member (#3736)

* InputSanitizer => HttpSanitizer, remove static

* Update cpp

* Clang format

Co-authored-by: Anton Kolesnyk <[email protected]>

* Increment version for keyvault releases (#3719)

* Increment package version after release of azure-security-keyvault-certificates

* Increment package version after release of azure-security-keyvault-secrets

* Update DistributedTracing.md (#3715)

Fix typo

* ApiView command line generation script (#3711)

* ApiView command line generation script

* Strongly typed parameters

Co-authored-by: Ben Broderick Phillips <[email protected]>

Co-authored-by: Anton Kolesnyk <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>

* Add missing license header to http_sanitizer source file (#3739)

* Add ResourceType parameter - Selects live test or perf test resources (#3740)

Co-authored-by: Mike Harder <[email protected]>

* Update identity codeowners (#3744)

* ManagedIdentityCredential: Add support for AppServiceV2019 (#3734)

* ManagedIdentityCredential: Add support for AppServiceV2019

* Attempt to create 2019 before 2017

* Changelog update

Co-authored-by: Anton Kolesnyk <[email protected]>

* sasa

* format file

Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: sima-zhu <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Patrick Hallisey <[email protected]>
Co-authored-by: Victor Vazquez <[email protected]>
Co-authored-by: Jeffrey Richter <[email protected]>
Co-authored-by: Larry Osterman <[email protected]>
Co-authored-by: Rick Winter <[email protected]>
Co-authored-by: Ahson Khan <[email protected]>
Co-authored-by: JinmingHu <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Victor Vazquez <[email protected]>
Co-authored-by: scbedd <[email protected]>
Co-authored-by: Anton Kolesnyk <[email protected]>
Co-authored-by: Anton Kolesnyk <[email protected]>
Co-authored-by: Ahson Khan <[email protected]>
Co-authored-by: Jeremi Piotrowski <[email protected]>
Co-authored-by: Christopher Scott <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: praveenkuttappan <[email protected]>
Co-authored-by: Mariana Rios Flores <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Mike Harder <[email protected]>

* Per request (#3770)

* Per request

* const

* Jeff feedback , clang, and test

* Updates from API review part 2 (#3775)

* Per request

* const

* Jeff feedback , clang, and test

* API review feedback updates, missed client to update , and some comments that somehow got reverted from the branch

* missed comment

* trigger

* some samll updates

* PR comments

* Fixed punctuation.

* one last  round

Co-authored-by: Anton Kolesnyk <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: sima-zhu <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Patrick Hallisey <[email protected]>
Co-authored-by: Victor Vazquez <[email protected]>
Co-authored-by: Jeffrey Richter <[email protected]>
Co-authored-by: Larry Osterman <[email protected]>
Co-authored-by: Rick Winter <[email protected]>
Co-authored-by: Ahson Khan <[email protected]>
Co-authored-by: JinmingHu <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Victor Vazquez <[email protected]>
Co-authored-by: scbedd <[email protected]>
Co-authored-by: Anton Kolesnyk <[email protected]>
Co-authored-by: Ahson Khan <[email protected]>
Co-authored-by: Jeremi Piotrowski <[email protected]>
Co-authored-by: Christopher Scott <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: praveenkuttappan <[email protected]>
Co-authored-by: Mariana Rios Flores <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
  • Loading branch information
1 parent 2bf0d38 commit 31ddec2
Show file tree
Hide file tree
Showing 204 changed files with 6,155 additions and 3,945 deletions.
3 changes: 3 additions & 0 deletions .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
"sasia",
"scus",
"SDDL",
"sdpath",
"serializers",
"Seriot",
"southcentralus",
Expand All @@ -123,9 +124,11 @@
"unscoped",
"unskipped",
"UPNs",
"uaenorth",
"usgov",
"usgoviowa",
"usgovvirginia",
"westcentralus",
"vcpkg",
"Viet",
"Viktor",
Expand Down
6 changes: 3 additions & 3 deletions cmake-modules/FolderList.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ macro(GetFolderList project)
message ("project found ${project}")
message ("FLAG VALUE : ${FETCH_SOURCE_DEPS}")
if(${project} STREQUAL CERTIFICATES)
DownloadDepVersion(sdk/core azure-core 1.2.0)
DownloadDepVersion(sdk/core azure-core 1.5.0)
DownloadDepVersion(sdk/identity azure-identity 1.1.0)
elseif(${project} STREQUAL IDENTITY)
DownloadDepVersion(sdk/core azure-core 1.2.0)
elseif(${project} STREQUAL SECRETS)
DownloadDepVersion(sdk/core azure-core 1.2.0)
DownloadDepVersion(sdk/core azure-core 1.5.0)
DownloadDepVersion(sdk/identity azure-identity 1.1.0)
elseif(${project} STREQUAL KEYS)
DownloadDepVersion(sdk/core azure-core 1.2.0)
DownloadDepVersion(sdk/core azure-core 1.5.0)
DownloadDepVersion(sdk/identity azure-identity 1.1.0)
elseif(${project} STREQUAL STORAGE_COMMON)
DownloadDepVersion(sdk/core azure-core 1.5.0)
Expand Down
6 changes: 6 additions & 0 deletions eng/pipelines/templates/stages/archetype-sdk-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,14 @@ parameters:
default:
Public:
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
# TODO: Migrate location override into azure-sdk-tools eng/common
# See https://github.com/Azure/azure-sdk-tools/issues/3398
Location: 'westus'
Preview:
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources-preview)
# TODO: Migrate location override into azure-sdk-tools eng/common
# See https://github.com/Azure/azure-sdk-tools/issues/3398
Location: 'westus'
Canary:
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
Location: 'eastus2euap'
Expand Down
6 changes: 4 additions & 2 deletions eng/pipelines/templates/stages/platform-matrix-live.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,14 @@
"RunSamples": 1,
"WindowsCtestConfig": "-C Release"
},
"Win_x64_with_unit_test_libcurl": {
"HSM_Win_x64_with_unit_test_libcurl": {
"VCPKG_DEFAULT_TRIPLET": "x64-windows-static",
"CMAKE_GENERATOR_PLATFORM": "x64",
"CmakeArgs": " -DBUILD_TRANSPORT_CURL=ON -DBUILD_TESTING=ON -DRUN_LONG_UNIT_TESTS=ON -DBUILD_PERFORMANCE_TESTS=ON -DMSVC_USE_STATIC_CRT=ON ",
"BuildArgs": "-v --parallel 8 --config Release",
"WindowsCtestConfig": "-C Release"
"WindowsCtestConfig": "-C Release",
"KVLocation": "eastus2",
"EnableHSM": 1
},
"Win_x64_with_unit_samples_libcurl": {
"VcpkgInstall": "curl[winssl] openssl",
Expand Down
24 changes: 24 additions & 0 deletions sdk/core/azure-core-test/inc/azure/core/test/test_base.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,30 @@ namespace Azure { namespace Core { namespace Test {
return Azure::Core::_internal::StringExtensions::ToLower(testName);
}

/**
* @brief Get test name with suffix if ENV variable is set.
*
* @param sanitize Sanitize the input and remove special characters. Default true.
* @param suffixEnvName Env variable containing the suffix. Default AZURE_LIVE_TEST_SUFFIX.
*
* @returns Test name.
*/
std::string GetTestNameSuffix(
bool sanitize = true,
std::string suffixEnvName = "AZURE_LIVE_TEST_SUFFIX")
{
std::string baseValue = Azure::Core::Test::TestBase::GetTestName(sanitize);

std::string suffix = Azure::Core::_internal::Environment::GetVariable(suffixEnvName.c_str());

if (suffix.length() > 0)
{
baseValue = "-" + suffix;
}

return baseValue;
}

// Creates the sdk client for testing.
// The client will be set for record and playback before it is created.
Azure::Core::Credentials::TokenCredentialOptions GetTokenCredentialOptions()
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ stages:
- Name: AZURE_KEYVAULT_URL
Value: "https://non-real-account.vault.azure.net"
- Name: AZURE_KEYVAULT_HSM_URL
Value: "https://non-real-account.vault.azure.net"
# Key Vault & Identity
Value: "https://non-real-account.managedhsm.azure.net/"
# Key Vault & Identity
- Name: AZURE_TENANT_ID
Value: "33333333-3333-3333-3333-333333333333"
- Name: AZURE_CLIENT_ID
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

### Features Added

### Breaking Changes
- Keyvault 7.3 support added for Certificates.

### Bugs Fixed
### Breaking Changes

### Other Changes
- Removed ServiceVersion type, replaced with Version field in the CertificateClientOptions type.

## 4.0.0 (2022-06-07)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ if(FETCH_SOURCE_DEPS)
add_subdirectory(${oneFolder} EXCLUDE_FROM_ALL)
endforeach()
elseif(NOT AZ_ALL_LIBRARIES)
find_package(azure-core-cpp "1.2.0" CONFIG QUIET)
find_package(azure-core-cpp "1.5.0" CONFIG QUIET)
if(NOT azure-core-cpp_FOUND)
find_package(azure-core-cpp "1.2.0" REQUIRED)
find_package(azure-core-cpp "1.5.0" REQUIRED)
endif()
endif()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,10 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Certificat
* @brief Imports a certificate into a specified key vault.
*
* @details Imports an existing valid certificate, containing a private key, into Azure Key
* Vault. The certificate to be imported can be in either PFX or PEM format. If the certificate
* is in PEM format the PEM file must contain the key as well as x509 certificates.
* Vault. This operation requires the certificates/import permission. The certificate to be
* imported can be in either PFX or PEM format. If the certificate is in PEM format the PEM file
* must contain the key as well as x509 certificates. Key Vault will only accept a key in PKCS#8
* format.
*
* @remark This operation requires the certificates/import permission.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,59 +18,23 @@

namespace Azure { namespace Security { namespace KeyVault { namespace Certificates {

/**
* @brief The API version to use from Key Vault.
*
*/
class ServiceVersion final {
private:
std::string m_version;

public:
/**
* @brief Construct a new Service Version object
*
* @param version The string version for the Key Vault Certificate service.
*/
ServiceVersion(std::string version) : m_version(std::move(version)) {}

/**
* @brief Enable comparing the ext enum.
*
* @param other Another #ServiceVersion to be compared.
*/
bool operator==(ServiceVersion const& other) const { return m_version == other.m_version; }

/**
* @brief Return the #ServiceVersion string representation.
*
*/
std::string const& ToString() const { return m_version; }

/**
* @brief Use to send request to the 7.2 version of Key Vault service.
*
*/
AZ_SECURITY_KEYVAULT_CERTIFICATES_DLLEXPORT static const ServiceVersion V7_2;
};

/**
* @brief Define the options to create an SDK Certificate client.
*
*/
struct CertificateClientOptions final : public Azure::Core::_internal::ClientOptions
{
ServiceVersion Version;
/**
* @brief Service Version used.
*
*/
std::string Version;

/**
* @brief Construct a new Certificate Client Options object.
*
* @param version Optional version for the client.
*/
CertificateClientOptions(ServiceVersion version = ServiceVersion::V7_2)
: Azure::Core::_internal::ClientOptions(), Version(version)
{
}
CertificateClientOptions() : Azure::Core::_internal::ClientOptions() { Version = "7.3"; }
};

}}}} // namespace Azure::Security::KeyVault::Certificates
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ CertificateClient::CertificateClient(
std::string const& vaultUrl,
std::shared_ptr<Core::Credentials::TokenCredential const> credential,
CertificateClientOptions options)
: m_vaultUrl(vaultUrl), m_apiVersion(options.Version.ToString())
: m_vaultUrl(vaultUrl), m_apiVersion(options.Version)
{
auto apiVersion = options.Version.ToString();
auto apiVersion = options.Version;

std::vector<std::unique_ptr<HttpPolicy>> perRetrypolicies;
{
Expand Down Expand Up @@ -493,5 +493,3 @@ Azure::Response<KeyVaultCertificate> CertificateClient::UpdateCertificatePropert
auto value = KeyVaultCertificateSerializer::Deserialize(certificateName, *rawResponse);
return Azure::Response<KeyVaultCertificate>(std::move(value), std::move(rawResponse));
}

const ServiceVersion ServiceVersion::V7_2("7.2");
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,14 @@ namespace Azure {
}

public:
// Reads the current test instance name.
// Name gets also sanitized (special chars are removed) to avoid issues when recording or
// creating. This also return the name with suffix if the "AZURE_LIVE_TEST_SUFFIX" exists.
std::string GetTestName(bool sanitize = true)
{
return Azure::Core::Test::TestBase::GetTestNameSuffix(sanitize);
}

template <class T>
static inline void CheckValidResponse(
Azure::Response<T>& response,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -888,3 +888,22 @@ TEST_F(KeyVaultCertificateClientTest, DISABLED_MergeCertificate)
}
}
}

TEST_F(KeyVaultCertificateClientTest, ServiceVersion)
{
auto credential
= std::make_shared<Azure::Identity::ClientSecretCredential>("tenantID", "AppId", "SecretId");
{
// 7.3
EXPECT_NO_THROW(auto options = CertificateClientOptions(); CertificateClient certificateClient(
"http://account.vault.azure.net", credential, options);
EXPECT_EQ(options.Version, "7.3"););
}
{
// arbitrary version
EXPECT_NO_THROW(
auto options = CertificateClientOptions(); options.Version = "1.0";
CertificateClient certificateClient("http://account.vault.azure.net", credential, options);
EXPECT_EQ(options.Version, "1.0"););
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"content-type": "application/json; charset=utf-8",
"date": "Thu, 04 Nov 2021 20:50:19 GMT",
"expires": "-1",
"location": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate/pending?api-version=7.2&request_id=3cfb9101c7564c10aecea528cf7cfd2b",
"location": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate/pending?api-version=7.3&request_id=3cfb9101c7564c10aecea528cf7cfd2b",
"pragma": "no-cache",
"retry-after": "10",
"strict-transport-security": "max-age=31536000;includeSubDomains",
Expand All @@ -27,7 +27,7 @@
"x-ms-request-id": "d16cb002-79c3-4f0a-b137-e396c501ad30",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate/create?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate/create?api-version=7.3"
},
{
"Headers": {
Expand Down Expand Up @@ -55,7 +55,7 @@
"x-ms-request-id": "ca4201e0-ba70-4b7e-aed7-0c65e8023441",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate/pending?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate/pending?api-version=7.3"
},
{
"Headers": {
Expand All @@ -82,7 +82,7 @@
"x-ms-request-id": "715c17a8-3473-46ce-adc5-87b01dc4b7df",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate/pending?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate/pending?api-version=7.3"
},
{
"Headers": {
Expand All @@ -109,7 +109,7 @@
"x-ms-request-id": "1396e2ed-d3a6-4413-84de-e70144b46a97",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate?api-version=7.3"
},
{
"Headers": {
Expand All @@ -136,7 +136,7 @@
"x-ms-request-id": "f6ad775e-ab79-462b-9d9f-d1ae4631fc43",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate/backup?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate/backup?api-version=7.3"
},
{
"Headers": {
Expand All @@ -163,7 +163,7 @@
"x-ms-request-id": "b761851a-58a0-4528-89bd-007797960b6e",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/certificates/BackupRestoreCertificate?api-version=7.3"
},
{
"Headers": {
Expand All @@ -190,7 +190,7 @@
"x-ms-request-id": "ec4ff08f-4e2f-49a7-8160-151b568a0e77",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedcertificates/BackupRestoreCertificate?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedcertificates/BackupRestoreCertificate?api-version=7.3"
},
{
"Headers": {
Expand All @@ -217,7 +217,7 @@
"x-ms-request-id": "3d6c9538-c07c-43d0-89b4-211c07c342f9",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedcertificates/BackupRestoreCertificate?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedcertificates/BackupRestoreCertificate?api-version=7.3"
},
{
"Headers": {
Expand All @@ -242,7 +242,7 @@
"x-ms-request-id": "84d82ad6-89bf-4378-a194-895a49271cf5",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/deletedcertificates/BackupRestoreCertificate?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/deletedcertificates/BackupRestoreCertificate?api-version=7.3"
},
{
"Headers": {
Expand All @@ -269,7 +269,7 @@
"x-ms-request-id": "1cacb00a-ad4c-4fc9-a546-b1d44e4002b1",
"x-powered-by": "ASP.NET"
},
"Url": "https://REDACTED.vault.azure.net/certificates/restore?api-version=7.2"
"Url": "https://REDACTED.vault.azure.net/certificates/restore?api-version=7.3"
}
]
}
Loading

0 comments on commit 31ddec2

Please sign in to comment.