Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test recordings for KV #5124

Closed
wants to merge 4 commits into from
Closed

Updated test recordings for KV #5124

wants to merge 4 commits into from

Conversation

gearama
Copy link
Member

@gearama gearama commented Nov 7, 2023

closes #5112

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

@gearama gearama enabled auto-merge (squash) November 7, 2023 21:10
Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's better fix it - #5129

@antkmsft antkmsft closed this Nov 8, 2023
auto-merge was automatically disabled November 8, 2023 05:33

Pull request was closed

@gearama
Copy link
Member Author

gearama commented Nov 8, 2023

#5129

@gearama gearama deleted the KVTestFix branch January 16, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

KeyVault: Fix test failures
2 participants