[Storage] Lower Case Query Param Keys in String to Sign (#21262)

* fixed string to sign issue * fixed test and added changelog
Azure · Jul 27, 2023 · c83d84e · c83d84e
1 parent 567ea3e
commit c83d84e
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 5 deletions.
diff --git a/sdk/storage/azblob/CHANGELOG.md b/sdk/storage/azblob/CHANGELOG.md
@@ -7,6 +7,7 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+* Fixed issue where some requests fail with mismatch in string to sign. 
 
 * Fixed service SAS creation where expiry time or permissions can be omitted when stored access policy is used. Fixes [#21229](https://github.com/Azure/azure-sdk-for-go/issues/21229).
 

diff --git a/sdk/storage/azblob/assets.json b/sdk/storage/azblob/assets.json
@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "go",
   "TagPrefix": "go/storage/azblob",
-  "Tag": "go/storage/azblob_a772b9c866"
+  "Tag": "go/storage/azblob_0776f1b95b"
 }
diff --git a/sdk/storage/azblob/internal/exported/shared_key_credential.go b/sdk/storage/azblob/internal/exported/shared_key_credential.go
@@ -172,7 +172,7 @@ func (c *SharedKeyCredential) buildCanonicalizedResource(u *url.URL) (string, er
 
 			// Join the sorted key values separated by ','
 			// Then prepend "keyName:"; then add this string to the buffer
-			cr.WriteString("\n" + paramName + ":" + strings.Join(paramValues, ","))
+			cr.WriteString("\n" + strings.ToLower(paramName) + ":" + strings.Join(paramValues, ","))
 		}
 	}
 	return cr.String(), nil

diff --git a/sdk/storage/azfile/CHANGELOG.md b/sdk/storage/azfile/CHANGELOG.md
@@ -7,6 +7,7 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+* Fixed issue where some requests fail with mismatch in string to sign.
 
 ### Other Changes
 

diff --git a/sdk/storage/azfile/internal/exported/shared_key_credential.go b/sdk/storage/azfile/internal/exported/shared_key_credential.go
@@ -172,7 +172,7 @@ func (c *SharedKeyCredential) buildCanonicalizedResource(u *url.URL) (string, er
 
 			// Join the sorted key values separated by ','
 			// Then prepend "keyName:"; then add this string to the buffer
-			cr.WriteString("\n" + paramName + ":" + strings.Join(paramValues, ","))
+			cr.WriteString("\n" + strings.ToLower(paramName) + ":" + strings.Join(paramValues, ","))
 		}
 	}
 	return cr.String(), nil

diff --git a/sdk/storage/azqueue/CHANGELOG.md b/sdk/storage/azqueue/CHANGELOG.md
@@ -7,7 +7,7 @@
 #### Breaking Changes
 
 #### Bugs Fixed
-
+* Fixed issue where some requests fail with mismatch in string to sign.
 * Fixed service SAS creation where expiry time or permissions can be omitted when stored access policy is used.
 
 #### Other Changes

diff --git a/sdk/storage/azqueue/internal/exported/shared_key_credential.go b/sdk/storage/azqueue/internal/exported/shared_key_credential.go
@@ -172,7 +172,7 @@ func (c *SharedKeyCredential) buildCanonicalizedResource(u *url.URL) (string, er
 
 			// Join the sorted key values separated by ','
 			// Then prepend "keyName:"; then add this string to the buffer
-			cr.WriteString("\n" + paramName + ":" + strings.Join(paramValues, ","))
+			cr.WriteString("\n" + strings.ToLower(paramName) + ":" + strings.Join(paramValues, ","))
 		}
 	}
 	return cr.String(), nil