Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

legacy SDK - BotService needs regenerate to include breaking changes from Swagger #19944

Closed
magodo opened this issue Feb 3, 2023 · 1 comment
Closed

legacy SDK - BotService needs regenerate to include breaking changes from Swagger #19944

magodo opened this issue Feb 3, 2023 · 1 comment
Assignees
@tadelesh
Labels
Bot Service Mgmt This issue is related to a management-plane library. Previous Versions Work related to track1 and track1.5 SDKs

Comments

@magodo
Copy link
Contributor

magodo commented Feb 3, 2023 •
edited
Loading

Service Package Request

Breaking changes are introduced in: https://github.com/Azure/azure-rest-api-specs/pull/22077/files#diff-1a1e934f09320fd0a63bb514460cb21c92fc67bcedb9b470d83a00e28e64c706L2046. While the current SDK is still generated from a commit prior to Azure/azure-rest-api-specs#22077. There needs a regenerate for those existing versions.

At least, the 2021-05-01-preview is impacted for terraform users.

@tadelesh I saw you approved this breaking change, do you think it makes sense to always update the impacted packages accordingly, to make the SDK up to date?
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 3, 2023
@jhendrixMSFT jhendrixMSFT added Mgmt This issue is related to a management-plane library. Bot Service Previous Versions Work related to track1 and track1.5 SDKs and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 3, 2023
@tadelesh
Copy link
Member

tadelesh commented Feb 8, 2023

We have officially announced the deprecation of previous version of Go SDK. We strongly encourage customer to migrate to the new version of Go SDK. Any further release of previous version of Go SDK will be limited within security fix or high business impact requirements.

@tadelesh tadelesh closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2023
magodo added a commit to magodo/kermit that referenced this issue Feb 8, 2023
@magodo
Config: Add botservice 2021-05-01-preview
373a22b 
The reason to add this is because the provider is currently using the same version for track1, but the track1 SDK is generated from a broken swagger version, which technically need to be regenerated, but they rejected to regenerate for track1 for such case. See Azure/azure-sdk-for-go#19944.
@magodo magodo mentioned this issue Feb 8, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tadelesh tadelesh

Labels
Bot Service Mgmt This issue is related to a management-plane library. Previous Versions Work related to track1 and track1.5 SDKs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tadelesh @magodo @jhendrixMSFT