Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename azsecrets options to match their methods #17886

Closed
wants to merge 1 commit into from
Closed

Rename azsecrets options to match their methods #17886

wants to merge 1 commit into from

Conversation

chlowell
Copy link
Member

Found a couple of options types that weren't renamed when their corresponding methods were.

@chlowell chlowell added KeyVault Client This issue points to a problem in the data-plane of the library. labels May 11, 2022
@chlowell chlowell requested a review from jhendrixMSFT as a code owner May 11, 2022 18:09
richardpark-msft
richardpark-msft approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then there'll be a pager rename (after this at some point)

@chlowell
Copy link
Member Author

I'll merge this into the new module once we have it.

@chlowell
Copy link
Member Author

Included this in #17982

@chlowell chlowell closed this May 16, 2022
@chlowell chlowell deleted the rename-options branch March 8, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

@RickWinter RickWinter RickWinter approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@richardpark-msft richardpark-msft richardpark-msft approved these changes

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chlowell @JeffreyRichter @RickWinter @jhendrixMSFT @richardpark-msft