Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove marsshal and unmarshal modification in changelog #18271

Merged
merged 1 commit into from
May 30, 2022

Conversation

tadelesh
Copy link
Member

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@tadelesh tadelesh requested a review from ArcturusZhang May 30, 2022 04:20
@tadelesh tadelesh requested review from benbp and weshaggard as code owners May 30, 2022 04:20
@tadelesh tadelesh linked an issue May 30, 2022 that may be closed by this pull request
@tadelesh
Copy link
Member Author

/azp run go - generator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tadelesh tadelesh force-pushed the update_release_v2 branch 3 times, most recently from f4ac22d to 7f7cc4e Compare May 30, 2022 07:52
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run go - [service] - ci

@tadelesh tadelesh force-pushed the update_release_v2 branch from 7f7cc4e to 61ce965 Compare May 30, 2022 08:26
@tadelesh
Copy link
Member Author

/check-enforcer override

@tadelesh
Copy link
Member Author

Override check enforcer because of some issue for the recent added Dump Package properties.

@tadelesh tadelesh merged commit 883d234 into Azure:main May 30, 2022
@tadelesh tadelesh deleted the update_release_v2 branch May 31, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tool to handle major version upgrade of release
2 participants