[azservicebus] Fixing bug from #23893, where a message could be received in the mess… #23929
+261
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message releaser, but not released, which would cause it to expire. Added some tests for this scenario, and a lot of comments to explain how we (now) avoid it. Also, go get -u'd all the deps, just to keep pace.
richardpark-msft
requested review from
chlowell and
jhendrixMSFT
as code owners
jhendrixMSFT
reviewed
Jan 9, 2025
added 3 commits
January 9, 2025 13:33
- Fixing one of the tests - Receive() doesn't get called twice anymore. - Fixing another test to account for sometimes getting more than a single message when doing the time.Nanosecond ReceiveMessages call.
…aser. There are better tests that cover the same area so removing this is no big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible for the message releaser to receive a message, but not release it. When that happened the message would be locked by SB, but not released, so you'd see it constantly get redelivered but never see it in your code.
Added some tests for this scenario, and a lot of comments to explain how we (now) avoid it.
Also, go get -u'd all the deps, just to keep pace.
Fixes #23893