Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between standard and URL encoding #9755

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

jhendrixMSFT
Copy link
Member

Swagger specifies 'byte' format for standard base-64 encoding and
'base64url' for base-64 URL encoding. Update the byte array encoder
and decoder to specify which type to use.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • The PR targets the latest branch.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • Apache v2 license headers are included in each file.

Swagger specifies 'byte' format for standard base-64 encoding and
'base64url' for base-64 URL encoding.  Update the byte array encoder
and decoder to specify which type to use.
@jhendrixMSFT
Copy link
Member Author

For Azure/autorest.go#243

@azuresdkci
Copy link

Can one of the admins verify this patch?

Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhendrixMSFT jhendrixMSFT merged commit 5d6b6fc into Azure:master Jun 1, 2020
@jhendrixMSFT jhendrixMSFT deleted the azcore_urlencoding branch June 1, 2020 21:31
jhendrixMSFT added a commit that referenced this pull request Jun 4, 2020
* Sync eng/common directory with azure-sdk-tools repository (#8089)

* Major release v41.0.0 (#8091)

* Update dependencies

* Generated from latest swagger

* v41.0.0

* Revert problematic package search/mgmt/2020-03-13

* Minor release v41.1.0 (#8117)

* Generated from recoveryservicesbackup (tag package-2020-02)

* v41.1.0

* Minor release v41.2.0 (#8196)

* Generated from eventgrid (tag package-2020-04-preview)

* Generated from synapse (tag package-2019-06-01-preview)

* v41.2.0

* Minor release v41.3.0 (#8445)

* Update autorest.go version

* Generated from kubernetesconfiguration (tag package-2019-11-01-preview)

* Generated from network (tag package-2020-03)

* Generated from storage (tag package-2019-06)

* Generated from cognitiveservices (tag release_3_0)

* Generated from cognitiveservices (tag release_3_2)

* v41.3.0

* Major version release v42.0.0 (#8605)

* Generated from latest swagger

* v42.0.0

* Enable Check Enforcer (#8601)

* Updating RetryAfter on azcore.Response to only return duration (#8666)

* Updating RetryAfter on azcore.Response to only return duration

* updating doc comment

Co-authored-by: Catalina Peralta <[email protected]>

* Minor release v42.1.0 (#8898)

* Generated from databricks (tag package-2018-04-01)

* v42.1.0

* Change RetryAfter() to a function (#9285)

Since azcore.Response isn't directly exposed to callers they cannot use
this convenience method.  Changed it to a function.

* Minor release v42.2.0 (#9275)

* Generated from network (tag package-2020-04)

* Generated from postgresql (tag package-2020-01-01)

* Generated from mysql (tag package-2020-01-01)

* Generated from imagebuilder (tag package-2020-02)

* v42.2.0

* Update label (#9478)

* Minor release v42.3.0 (#9485)

* Generated from eventgrid (tag package-2020-04-preview)

* Generated from subscription (tag package-2019-10-preview)

* Generated from resourcegraph

* v42.3.0

* Add support for base-64 encoding and decoding of payloads (#9666)

* Differentiate between standard and URL encoding (#9755)

Swagger specifies 'byte' format for standard base-64 encoding and
'base64url' for base-64 URL encoding.  Update the byte array encoder
and decoder to specify which type to use.

* Major version release v43.0.0 (#9756)

* Update autorest.go version

* Generated from latest swagger

* v43.0.0

* Fix for path of billing 2020-05-01-preview

* Modified changelog accordingly

Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Arcturus <[email protected]>
Co-authored-by: Mitch Denny <[email protected]>
Co-authored-by: catalinaperalta <[email protected]>
Co-authored-by: Catalina Peralta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants