mgmt, regen appplatform #15306
Merged
mgmt, regen appplatform #15306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
requested review from
ChenTanyi,
xseeseesee and
yungezz
as code owners
ChenTanyi
approved these changes
Sep 17, 2020
Comment on lines
+125
to
+127
| // use following option in api-specs.json, if modelerfour reports PreCheck error (current seems occur to containerinstance, sql). | ||
| //--pipeline.modelerfour.additional-checks=false | ||
| //--pipeline.modelerfour.lenient-model-deduplication=true |
There was a problem hiding this comment.
I've disabled the override on m4 check in autorest.java
We might likely see m4 check failure on next time code generation. We can decide later whether to put it here for all, or in api-specs for single service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regen appplatform after they fixed the swagger.