-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication - Added release phone number LRO #16821
Merged
jbeauregardb
merged 6 commits into
Azure:master
from
jbeauregardb:releasePhoneNumberLRO
Oct 29, 2020
Merged
Communication - Added release phone number LRO #16821
jbeauregardb
merged 6 commits into
Azure:master
from
jbeauregardb:releasePhoneNumberLRO
Oct 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeauregardb
requested review from
ankitarorabit,
JianpingChen,
RezaJooyandeh and
a team
as code owners
October 26, 2020 20:30
jbeauregardb
force-pushed
the
releasePhoneNumberLRO
branch
5 times, most recently
from
October 26, 2020 22:11
ee49692
to
5ec46e1
Compare
minnieliu
reviewed
Oct 26, 2020
...ommunication-administration/src/test/resources/session-records/beginReleasePhoneNumbers.json
Show resolved
Hide resolved
minnieliu
reviewed
Oct 26, 2020
jbeauregardb
force-pushed
the
releasePhoneNumberLRO
branch
3 times, most recently
from
October 27, 2020 16:42
55eb6df
to
027efb7
Compare
jbeauregardb
force-pushed
the
releasePhoneNumberLRO
branch
from
October 28, 2020 19:06
027efb7
to
f4644d2
Compare
...inistration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java
Outdated
Show resolved
Hide resolved
...inistration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java
Outdated
Show resolved
Hide resolved
.../test/java/com/azure/communication/administration/PhoneNumberAsyncClientIntegrationTest.java
Outdated
Show resolved
Hide resolved
...inistration/src/main/java/com/azure/communication/administration/PhoneNumberAsyncClient.java
Show resolved
Hide resolved
ankitarorabit
requested changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments
jbeauregardb
force-pushed
the
releasePhoneNumberLRO
branch
from
October 29, 2020 19:23
5511c0d
to
6cb5892
Compare
ankitarorabit
approved these changes
Oct 29, 2020
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.