Fixed Inappropriate Logging and String.format Usage #22450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
the
Client
alzimmermsft
requested review from
aayush3011,
abhipsaMisra,
anuchandy,
azabbasi,
barustum,
bikamani,
conniey,
digimaun,
drwill-ms,
FabianMeiswinkel,
g2vinay,
hemanttanwar,
jianghaolu,
JonathanGiles,
joshfree,
kirankumarkolli,
kushagraThapar,
lmolkova,
mbhaskar,
milismsft,
moderakh,
mssfang,
samvaity,
schaabs,
simplynaveen20 and
srnagar
as code owners
alzimmermsft
requested review from
trask,
vcolin7,
vinagesh,
xinlian12,
YijunXieMS and
yvgopal
as code owners
ghost
added
App Configuration
samvaity
approved these changes
Jun 22, 2021
...e-quality-reports/src/main/java/com/azure/tools/checkstyle/checks/FluentMethodNameCheck.java
Show resolved
Hide resolved
alzimmermsft
requested review from
amishra-dev,
gapra-msft,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
drwill-ms
approved these changes
Jun 22, 2021
vcolin7
approved these changes
Jun 22, 2021
...g-eventhubs/src/test/java/com/azure/messaging/eventhubs/EventProcessorClientBuilderTest.java
Outdated
Show resolved
Hide resolved
kushagraThapar
approved these changes
Jun 22, 2021
srnagar
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22443
This PR fixes a few cases where
ClientLoggerandString.formatare being used inappropriately. Inappropriate usage is string manipulation before passing into the logger or missing/using incorrect placeholders.