Fixed double decoding in getBlobName #22825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickle-msft
requested review from
alzimmermsft,
amishra-dev,
gapra-msft,
jaschrep-msft and
kasobol-msft
as code owners
ghost
added
the
gapra-msft
approved these changes
Jul 7, 2021
kasobol-msft
approved these changes
Jul 7, 2021
| resultName == bc.getBlobName() | ||
|
|
||
| where: | ||
| name | resultName |
There was a problem hiding this comment.
how about expected name?
There was a problem hiding this comment.
inputName and outputName?
There was a problem hiding this comment.
def inputName = "bla"
def expectedOutputName = "bla I think I'll get"
def outputName = bc.getBlobName()
assert outputName = expectedOutputName
That's if I were most explicit.
inputName and expectedOutputName might suffice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22722
I checked other packages for object-level getName() methods, and this seems to be the only instance of this