Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass GPG Directory as Parameter to templates #23800

Merged
merged 2 commits into from
Sep 4, 2021
Merged

Pass GPG Directory as Parameter to templates #23800

merged 2 commits into from
Sep 4, 2021

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Aug 27, 2021 •
edited
Loading

@weshaggard weshaggard requested a review from hallipr August 31, 2021 20:54
@hallipr
Copy link
Member

hallipr commented Sep 2, 2021 •
edited
Loading

Do we do anything else with $GPGToolDirectory other than set $GPGExecutablePath = $GPGToolDirectory\gpg.exe? Or, should we just replace $BuildToolsPath and its implicit $GPGExecutablePath with an explicit $GPGExecutablePath instead of replacing one implicit path with another?

Is it possible that someone won't have gpg.exe in $GPGToolDirectory and would prefer to use $GPGExecutablePath = 'some/path/to/gpg-1.2.3.beta.exe'?

@chidozieononiwu
Copy link
Member Author

Do we do anything else with $GPGToolDirectory other than set $GPGExecutablePath = $GPGToolDirectory\gpg.exe? Or, should we just replace $BuildToolsPath and its implicit $GPGExecutablePath with an explicit $GPGExecutablePath instead of replacing one implicit path with another?

Is it possible that someone won't have gpg.exe in $GPGToolDirectory and would prefer to use $GPGExecutablePath = 'some/path/to/gpg-1.2.3.beta.exe'?

I have updated that. Please also take a look at https://dev.azure.com/azure-sdk/internal/_git/azure-sdk-build-tools/pullrequest/200

@chidozieononiwu
Copy link
Member Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chidozieononiwu
Copy link
Member Author

/check-enforcer override

@chidozieononiwu
Copy link
Member Author

Tested with this build https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1081774&view=results

@chidozieononiwu chidozieononiwu merged commit 011fc8a into Azure:main Sep 4, 2021
@JimSuplizio JimSuplizio mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

@hallipr hallipr hallipr approved these changes

@weshaggard weshaggard weshaggard approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Decouple knowledge gpg tooling location.
4 participants
@chidozieononiwu @hallipr @benbp @weshaggard