SwitchOffIOThread #23822
Merged
SwitchOffIOThread #23822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
requested review from
aayush3011,
FabianMeiswinkel,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh and
simplynaveen20
as code owners
ghost
added
the
added 2 commits
August 30, 2021 12:28
...cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/TransportClient.java
Show resolved
Hide resolved
...cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/TransportClient.java
Outdated
Show resolved
Hide resolved
...main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdServiceEndpoint.java
Outdated
Show resolved
Hide resolved
simplynaveen20
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
LGTM , thanks @xinlian12 , please merge once we run the perf
moderakh
reviewed
Aug 30, 2021
...main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdServiceEndpoint.java
Outdated
Show resolved
Hide resolved
| @@ -16,4 +17,11 @@ | |||
| COSMOS_PARALLEL_THREAD_NAME, | |||
| Schedulers.DEFAULT_POOL_SIZE, | |||
| true); | |||
|
|
|||
| // Custom bounded elastic scheduler to switch off IO thread to process response. | |||
| public final static Scheduler TRANSPORT_RESPONSE_BOUNDED_ELASTIC = Schedulers.newBoundedElastic( | |||
There was a problem hiding this comment.
does this need to be released as a resource when the client is closed?
There was a problem hiding this comment.
I think yes, we need to dispose it when the client gets closed, otherwise it will not let JVM shut down.
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/CosmosSchedulers.java
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
requested changes
Aug 31, 2021
...cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/TransportClient.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Configs.java
Show resolved
Hide resolved
| @@ -16,4 +17,11 @@ | |||
| COSMOS_PARALLEL_THREAD_NAME, | |||
| Schedulers.DEFAULT_POOL_SIZE, | |||
| true); | |||
|
|
|||
| // Custom bounded elastic scheduler to switch off IO thread to process response. | |||
| public final static Scheduler TRANSPORT_RESPONSE_BOUNDED_ELASTIC = Schedulers.newBoundedElastic( | |||
There was a problem hiding this comment.
I think yes, we need to dispose it when the client gets closed, otherwise it will not let JVM shut down.
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/CosmosSchedulers.java
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
approved these changes
Sep 2, 2021
moderakh
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark Tests:
BoundedElastic Scheduler vs Parallel Scheduler:
Daemon vs UserThread:
