Update HttpResponseError based on arch board feedback #23910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srnagar
requested review from
alzimmermsft,
anuchandy,
jianghaolu,
lmolkova,
mssfang,
pallavit and
vcolin7
as code owners
ghost
added
the
alzimmermsft
reviewed
Sep 4, 2021
| @@ -74,7 +74,7 @@ public String getTarget() { | |||
| * @param target the target of this error. | |||
| * @return the updated {@link HttpResponseError} instance. | |||
| */ | |||
| public HttpResponseError setTarget(String target) { | |||
| HttpResponseError setTarget(String target) { | |||
There was a problem hiding this comment.
Should this class be removed from the public API?
Also, I thought this was going to be ResponseError instead of HttpResponseError.
There was a problem hiding this comment.
I moved this to core-experimental as the arch board feedback was not conclusive on the naming. I'll follow up with @JonathanGiles to finalize the name.
vcolin7
reviewed
Sep 4, 2021
sdk/core/azure-core/src/main/java/com/azure/core/models/HttpResponseError.java
Show resolved
Hide resolved
alzimmermsft
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.