Expose class information for TypeReference<T> #24568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API changes have been detected in API changes + public Class<T> getClazz() |
| final TypeReference<HashMap<String, Object>> typeReference = new TypeReference<HashMap<String, Object>>() {}; | ||
| final Map<String, Object> expectedJavaType = new HashMap<String, Object>() {}; | ||
| assertEquals(expectedJavaType.getClass().getGenericSuperclass(), typeReference.getJavaType()); | ||
| assertNull(typeReference.getClazz()); |
There was a problem hiding this comment.
I wonder if this should return the non-generic HashMap.class
| * @return The {@link Class} representing instance of the {@link TypeReference} created | ||
| * using the {@link TypeReference#createInstance(Class)}, otherwise returns {@code null}. | ||
| */ | ||
| public Class<T> getClazz() { |
There was a problem hiding this comment.
To follow the other API maybe rename this to getJavaClass
samvaity
requested review from
anuchandy,
JonathanGiles,
lmolkova,
mssfang,
pallavit,
srnagar and
vcolin7
as code owners
|
API changes have been detected in API changes + public interface ReferenceManager {
+ ReferenceManager INSTANCE = new ReferenceManagerImpl();
+ void register(Object object, Runnable cleanupAction)
+ }
- public Class<T> getClazz()
+ public Class<T> getJavaClass() |
alzimmermsft
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23745