Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS Rooms] Beta release version update #30442

Merged
merged 4 commits into from
Aug 12, 2022
Merged

[ACS Rooms] Beta release version update #30442

merged 4 commits into from
Aug 12, 2022

Conversation

elavarasidc
Copy link
Member

Description

[ACS Rooms] Beta release version update

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [] Pull request includes test coverage for the included changes.

@ghost ghost added the Communication label Aug 12, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

JimSuplizio
JimSuplizio approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this but you're going to need to push another commit with the update for the README.md's end tag.

@elavarasidc elavarasidc merged commit 5bbf6c4 into main Aug 12, 2022
@elavarasidc elavarasidc deleted the feature/ACS-Rooms-VersionUpdate branch August 12, 2022 17:54
vcolin7
vcolin7 approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@vcolin7 vcolin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good to me :)

@elavarasidc
Copy link
Member Author

Thanks vcolin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramneettung-msft ramneettung-msft ramneettung-msft left review comments

@JimSuplizio JimSuplizio JimSuplizio approved these changes

@radubulboaca radubulboaca radubulboaca approved these changes

@vcolin7 vcolin7 vcolin7 approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@samvaity samvaity Awaiting requested review from samvaity

@g2vinay g2vinay Awaiting requested review from g2vinay

@JianpingChen JianpingChen Awaiting requested review from JianpingChen

@ankitarorabit ankitarorabit Awaiting requested review from ankitarorabit

@minnieliu minnieliu Awaiting requested review from minnieliu minnieliu is a code owner

@srnagar srnagar Awaiting requested review from srnagar

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elavarasidc @azure-sdk @vcolin7 @JimSuplizio @radubulboaca @ramneettung-msft