Redact error output #36232
Merged
Redact error output #36232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was reported to me in which I observed that the exception message for the CLI process timing out can include a warning and then the access token. Azure CLI defaults to printing warnings. The fact that the output is not pure JSON causes us to fail parsing it, and the exception includes the token.
|
API change check API changes are not detected in this pull request. |
g2vinay
reviewed
Aug 3, 2023
...ntity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientBase.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was reported to me in which I observed that the process output for the CLI process can include a warning and then the access token JSON payload. Azure CLI defaults to printing warnings. The fact that the output is not pure JSON causes us to fail parsing it, and the exception includes the token.