Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for complete native support for remaining azure-resourcemanager libs #38513

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Fixed for complete native support for remaining azure-resourcemanager libs #38513

merged 9 commits into from
Feb 1, 2024

Conversation

v-hongli1
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The json file depends on the Java files generated via codegen.

Are you sure there is not even a single new file added, or old file removed/renamed?

@v-hongli1
Copy link
Member Author

v-hongli1 commented Jan 31, 2024

@weidongxu-microsoft
The situation as adding new files, or deleting/renaming old files not found in the submitted section.

@weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft The situation as adding new files, or deleting/renaming old files not found in the submitted section.

No. I mean is there any such case when you "generate" the code (but not included in submit).

@v-hongli1
Copy link
Member Author

@weidongxu-microsoft The situation as adding new files, or deleting/renaming old files not found in the submitted section.

No. I mean is there any such case when you "generate" the code (but not included in submit).

I have confirmed the generated codes one by one, and no such situation occurs except for monitor.

@v-hongli1 v-hongli1 merged commit aae066d into Azure:main Feb 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants