[WIP | Draft]: Drop the support for AMQP v1 stack #43735
Conversation
anuchandy
changed the title
… update the ServiceBusProcessorClient to remove the v1 processor code
|
API change check API changes are not detected in this pull request. |
|
/azp run java - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| * @throws InterruptedException If the test is interrupted. | ||
| */ | ||
| @Test | ||
| public void testReceivingMultiSessionMessagesWithProcessor() throws InterruptedException { |
There was a problem hiding this comment.
The ServiceBusSessionReceiverAsyncClient::ServiceBusReceiverAsyncClient is no longer responsible for internally pumping from "multiple" sessions, the v2 rework move this responsibility to SessionsMessagePump to address the out of order message delivery and the limited concurrency v1 had. The same case is now covered by
SessionsMessagePumpIsolatedTest::shouldPumpFromMultiSessionWhenBackingProcessor
| @@ -442,39 +367,7 @@ public void testProcessorWithTracingEnabled(boolean isV2) throws InterruptedExce | |||
|
|
|||
| @Test | |||
| @SuppressWarnings("unchecked") | |||
| public void testProcessorWithTracingEnabledAndNullMessage() throws InterruptedException { | |||
There was a problem hiding this comment.
This test is not required anymore since v2 no longer uses ServiceBusReceivedMessageContext to funnel error. Which means the instrumentation in v2 processor will no longer get error-ServiceBusReceivedMessageContext with no message. Originally, this test was added after a regression where instrumentation tried to access null message in such ServiceBusReceivedMessageContext leading to NPE
| * Integration tests for {@link ServiceBusSessionManager}. | ||
| */ | ||
| @Tag("integration") | ||
| class ServiceBusSessionManagerIntegrationTest extends IntegrationTestBase { |
There was a problem hiding this comment.
The ServiceBusReceiverAsyncClient is no longer act as the internal SessionManager pumping from "multiple" sessions, v2 moved that responsibility to the new SessionsMessagePump type to address the out of order message delivery and scaling. Valid cases in this test class are now covered by ServiceBusProcessorClientIntegrationTest and ServiceBusReceiverAsyncClientIntegrationTest
anuchandy
force-pushed
the
remove-amqp-v1-stack
branch
from
fae62c5 to
f911d46
Compare
|
/azp run java - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anuchandy
force-pushed
the
remove-amqp-v1-stack
branch
from
f911d46 to
bee48de
Compare
|
/azp run java - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…file, make the assert message for the test shouldPumpFromMultiSessionWhenBackingProcessor better
|
/azp run java - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
No description provided.