Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Incorrect logs related to actionAfterWaitTimeout - batching receiver #12232

Closed
HarshaNalluru opened this issue Nov 3, 2020 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Nov 3, 2020

actionAfterWaitTimeout

image

Timers are set at different times

  • totalWaitTimer = setTimeout(actionAfterWaitTimeout, args.maxWaitTimeInMs);
  • totalWaitTimer = setTimeout(actionAfterWaitTimeout, getRemainingWaitTimeInMs());

Consider the scenario - with the workflow

  • timer-1 is set - maxWaitTimeInMs = 10000
  • 1st message received at 1000 ms
  • timer-1 is cleared
  • timer-2 is added - getRemainingWaitTimeInMs() = 1000 ms
  • No messages received
  • timer-2 goes off
  • The log message would say Batching, max wait time in milliseconds 10000 over which is wrong, it should instead say 2000 ms

PS: Observed this while discussing the logs for #8875, #11633 with @anqyan (from the service-bus team)

TODO

Probably, pass the time as an argument for the actionAfterWaitTimeout just for the log statement and update the log statement accordingly.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 3, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Service Bus labels Nov 3, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 3, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] December milestone Nov 3, 2020
@ramya-rao-a
Copy link
Contributor

Done with #12322

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

2 participants