[Service Bus] Fix log message at actionAfterWaitTimeout
#12322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
HarshaNalluru
commented
Nov 6, 2020
HarshaNalluru
requested review from
chradek,
ramya-rao-a and
richardpark-msft
as code owners
ramya-rao-a
reviewed
Nov 9, 2020
HarshaNalluru
commented
Nov 9, 2020
chradek
approved these changes
Nov 9, 2020
| totalWaitTimer = setTimeout(actionAfterWaitTimeout, getRemainingWaitTimeInMs()); | ||
| const remainingWaitTimeInMs = getRemainingWaitTimeInMs(); | ||
| totalWaitTimer = setTimeout(() => { | ||
| actionAfterWaitTimeout( |
There was a problem hiding this comment.
Now that the message is being passed to actionAfterWaitTimeout I'm not sure there's much value to even having actionAfterWaitTimeout be a separate function, but that's just a personal nit.
There was a problem hiding this comment.
I agree. @HarshaNalluru, can we inline the code from actionAfterWaitTimeout here?
…luru/azure-sdk-for-js into harshan/sb/issue/12232
…to harshan/sb/issue/12232
ramya-rao-a
reviewed
Nov 10, 2020
ramya-rao-a
approved these changes
Nov 10, 2020
HarshaNalluru
commented
Nov 10, 2020
HarshaNalluru
commented
Nov 10, 2020
ramya-rao-a
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #12232