EPH HostContext calling client.close() in a fire-and-forget way

[jeremymeng]

continuing the discussion at #1390 (comment)

There are three places

• azure-sdk-for-js/packages/@azure/eventhubs/processor/lib/hostContext.ts

  Line 246 in 29fad66

  client.close().catch(/* do nothing */);

• azure-sdk-for-js/packages/@azure/eventhubs/processor/lib/hostContext.ts

  Line 252 in 29fad66

  client.close().catch(/* do nothing */);

• azure-sdk-for-js/packages/@azure/eventhubs/processor/lib/hostContext.ts

  Line 259 in 29fad66

  client.close().catch(/* do nothing */);

in HostContext where a client is created to retrieve hub information. The client is then closed in a fire-and-forget way, with any errors ignored

client.close.catch(/* do nothing */)

We would like to understand

• Is there any reason for the current behavior (fire-and-forget) while ignoring errors?
• If we are going to change to wait with await client.close(), do we need to catch errors in order to keep the behavior of swallowing all errors from client.close()?
• Is it possible to for the client have proper clean-up in the close() method in the exceptional cases?

azure-sdk-for-js/packages/@azure/eventhubs/client/lib/eventHubClient.ts

Lines 134 to 158 in 94e6116

	async close(): Promise<void> {
	try {
	if (this._context.connection.isOpen()) {
	// Close all the senders.
	for (const senderName of Object.keys(this._context.senders)) {
	await this._context.senders[senderName].close();
	}
	// Close all the receivers.
	for (const receiverName of Object.keys(this._context.receivers)) {
	await this._context.receivers[receiverName].close();
	}
	// Close the cbs session;
	await this._context.cbsSession.close();
	// Close the management session
	await this._context.managementSession!.close();
	await this._context.connection.close();
	this._context.wasConnectionCloseCalled = true;
	log.client("Closed the amqp connection '%s' on the client.", this._context.connectionId);
	}
	} catch (err) {
	const msg = `An error occurred while closing the connection "${this._context.connectionId}": ${JSON.stringify(err)}`;
	log.error(msg);
	throw new Error(msg);
	}
	}

[ramya-rao-a]

The latest update to the @azure/event-hubs library replaces the need for the @azure/event-processor-host library which is now in maintenance state.