[Azure App Configuration sdk] Running into 401 issue when there is a trailing '/' in store endpoint

[MaryanneNjeri]

• Package Name: @azure/app-configuration
• Package Version: 1.3.1
• Operating system:
• nodejs
  • version: 16.9.0
• browser
  • name/version:
• typescript
  • version: 4.0.2
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • SDK API docs on https://docs.microsoft.com

Describe the bug
When using the App configuration client and passing a configuration store endpoint with a trailing '/' and a credential from, am running into a 401 error.

To Reproduce
Steps to reproduce the behavior:

1. Using the App configuration client, pass a store endpoint with a trailing '/' and a credential.

Expected behavior
The Azure app configuration SDK should handle any trailing '/' in the store endpoint.

[xirzec]

@minhanh-phan can you take a look?

[HarshaNalluru]

Hey @MaryanneNjeri,

We've tested the SDK with your case, and it is working fine.
Can you share more details on the error?

[MaryanneNjeri]

Hey @HarshaNalluru thank you for helping look into this, am using the AppConfigurationClient passing the app configuration store endpoint with a trailing slash something like "https://store-name.azconfig.io/", and a clientSecretCredential and I run into this 401 error, with the response

{
  "name": "RestError",
  "statusCode": 401,
  "request": {
    "streamResponseStatusCodes": {},
    "url": REDACTED, // Censored
    "method": "GET",
    "headers": {
      "_headersMap": {
        "accept": "application/vnd.microsoft.appconfig.kvset+json, application/json, application/problem+json",
        "user-agent": "AzurePipelines.AzureAppConfiguration.Push/5.0.0 azsdk-js-app-configuration/1.3.1 core-http/2.2.4 Node/v16.19.0 OS/(x64-Windows_NT-10.0.22621)",
        "x-ms-client-request-id": "5a0e62c5-d2cb-4d51-8c86-b49a4f338526",
        "authorization": "REDACTED", // 
        "cookie": "REDACTED"
      }
    },
    "withCredentials": false,
    "timeout": 0,
    "requestId": "5a0e62c5-d2cb-4d51-8c86-b49a4f338526"
  },

The error object doesn't also give a lot of information on what the error could be. Expected result is that the SDK would handle any trailing "/" in the store endpoint

[HarshaNalluru]

@MaryanneNjeri
Looks like the error you see is not much informative, would you run the test by enabling logging?
Set "AZURE_LOG_LEVEL=verbose" environmental variable and provide us with the logs, which might be more helpful in understanding the problem.

[MaryanneNjeri]

@HarshaNalluru also the response headers indicate that

www-authenticate': {
      name: 'www-authenticate',
      value:  Bearer error="invalid_token", error_description="Authorization token failed validation"'

the token is invalid

[HarshaNalluru]

You said the problem is from the trailing "/" in the description.
Have you tried with an endpoint where there is no trailing "/" to confirm your theory?

The problem is probably from using a wrong credential. Can you verify?

[github-actions]

Hi @MaryanneNjeri. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

[MaryanneNjeri]

@HarshaNalluru Yes without the trailing "/" in the endpoint authentication is successful. This only happens when there is a trailing "/" in the endpoint.

[HarshaNalluru]

@MaryanneNjeri, good news, I could repro the issue with 1.3.1. Apologies.
And we had been testing with the unreleased 1.4.1 since we assumed there weren't any changes from 1.3.1 -> 1.4.1 impacting this issue.

Though the details may be boring, I'm sharing them here for future context.
The unnoticed fix went in when we migrated @azure/app-configuration to use the new core stack core-v2 for better maintainability and increased performance as part of #20766.

The fix is already in the source code and will be released as part of version 1.4.1, will release it soon.

[HarshaNalluru]

@MaryanneNjeri, Thanks for reporting.

@azure/app-configuration/v/1.4.1 has bene published to the npm

[MaryanneNjeri]

@HarshaNalluru Thank you so much, let me try it out