-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tables] Fix Shared Key auth and update Readme #10988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust that this behaves as expected, but is it easy enough for us to write a recorded test that gives us some coverage when using an account key so we have at least some coverage in our matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for adding the test. On small piece of feedback on one of the guards we have in a test, but it's not blocking.
sdk/tables/data-tables/test/integration/utils/recordedClient.ts
Outdated
Show resolved
Hide resolved
Command 'js' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
/azp run js - tables - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
SharedKey auth was broken since the authentication pipeline was not being created correctly and also the construction of the Canonicalized resource was faulty.
Fix:
I'm also including a couple of updates to the readme to fix small issues I noticed while running the samples