[app-config] Use createSpan from core-tracing #13942
Conversation
ghost
added
Azure.Core
App Configuration
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
sdk/appconfiguration/app-configuration/src/appConfigurationClient.ts
Outdated
Show resolved
Hide resolved
… it's own spans. - Reduced Spanner<T> to a single method (trace) - Testing simplified - Prep for otel 0.16+ upgrade that's coming.
richardpark-msft
force-pushed
the
ot-createSpanEverywhere-appconfig
branch
from
7fc6447 to
cc7c161
Compare
…sort of behavior like this more universally, and there's no reason to not do it.
|
/azp run js - app-configuration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - app-configuration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/appconfiguration/app-configuration/test/internal/tracingHelpers.spec.ts
Show resolved
Hide resolved
Release microsoft.sql 2021 02 01 preview (Azure#14339) * Adds base for updating Microsoft.Sql from version preview/2020-11-01-preview to version 2021-02-01-preview * Updates readme * Updates API version in new specs and examples * Fix Integer format: S360 swagger lint issues in 2021-02-01 (Azure#13855) * Update integer format * update typo * Swagger Documentation for Outbound Firewall Rules (Azure#13820) * Swagger Documentation for Outbound Firewall Rules * Add the new file to v5 Co-authored-by: Vineet Mahadik <[email protected]> * Swagger Documentation For Database Resource With Ledger (Azure#13916) * adding database swagger files * modifying example * Fixing to be boolean * adding database extensions and database operations * adding other database examples * removing database_legacy, adding usages * removing usages * removing databases_legacy from readme * Swagger Documentation For Ledger Digest Upload (Azure#13871) * adding ledger api * Fixes from validation * removing required endpoint parameter, adding ledgerName (current) to id * removing 201 response from resource, renaming ledgerName * adding location to 202 results * fixing 202 response location * renaming files * updating files with new controller name + correct entity name * fixing readme * Dev brandong getrestorabledropped (Azure#14129) * Update RestorableDroppedDatabases API to add BackupStorageAccountType property * Update readme.md * Re-add elasticPoolId as a deprecated property * Update elasticPoolId description and remove trailing comma causing failures * Remove the unsupported deprecated property * Add 2021-02-01-preview minor changes (Azure#13942) * add 2021-02-01-preview for test * update with 2021-04-19 latest * update readme.md * update with latest master in DSMainDev * Carry IsInfraEncryptionEnabled to Database.json (Azure#14322) * carry latest minor changes. * re-format readme.md * remove 2020 11 01 RestorableDroppedManagedDatabases in V5 * Update readme file in 2021 02 01 dev branch to match the master branch (Azure#14336) * Carry IsInfraEncryptionEnabled to Database.json (Azure#14322) * carry latest minor changes. * re-format readme.md * remove 2020 11 01 RestorableDroppedManagedDatabases in V5 * update to match master branch readme.md Co-authored-by: Vineet Mahadik <[email protected]> Co-authored-by: Vineet Mahadik <[email protected]> Co-authored-by: rewongmicrosoft <[email protected]> Co-authored-by: brandong-ms <[email protected]> Co-authored-by: Arthur Ning <[email protected]>
Updating AppConfiguration to point to core-tracing and remove all code that was attempting to manage span parenting.
This also mean I could finally gut Spanner - it's now down to just being a single trace<> function that wraps calling a function and handling calling .setSpanStatus() on error.