Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Document Translator] Update package metadata #14899

Merged
merged 12 commits into from
Apr 16, 2021
Merged

[Document Translator] Update package metadata #14899

merged 12 commits into from
Apr 16, 2021

Conversation

joheredi
Copy link
Member

@joheredi joheredi commented Apr 15, 2021 •
edited
Loading

  • Update package metadata for @azure-rest/ai-document-translator
  • Fix lint errors
  • Update lint rule to allow @azure-rest
  • Fix lint errors in search and metricsadvisor

@joheredi joheredi requested a review from ramya-rao-a as a code owner April 15, 2021 21:45
deyaaeldeen
deyaaeldeen approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joheredi joheredi requested a review from sarangan12 as a code owner April 16, 2021 02:05
deyaaeldeen
deyaaeldeen reviewed Apr 16, 2021
View reviewed changes
Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in the eslint plugin looks good. Can you please update the docs for the updated eslint rule to match the new behavior?

common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-name.ts Outdated
Comment on lines 91 to 95
function getSubScope(packageName: string): string | undefined {
// Check if there is a sub scope i.e @azure-rest
const [_, subScope] = packageName.match(/^@azure(-[a-z]+)?\//) ?? [];

return subScope;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to repurpose this function to return both the subscope and the package name in one pass. Perhaps, it will need to be renamed to getPackageMetadata or something like that.

chradek
chradek approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@chradek chradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I see this fixes the core-rest pipeline too!

@chradek chradek mentioned this pull request Apr 16, 2021
Merged
@joheredi joheredi merged commit 7b40d55 into Azure:master Apr 16, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Dec 14, 2021
@solankisamir @azaslonov
@yingru97 @JatinSanghvi @atharos1 @VitaliyKurokhtin @RupengLiu @msyyc
CodeGen from PR 16715 in Azure/azure-rest-api-specs
778a29f 
Schema resource added in REST API Spec for api-version 2021-08-01 (Azure#16715)

* Adds base for updating Microsoft.ApiManagement from version preview/2021-01-01-preview to version 2021-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Added support for GraphQL API type (Azure#14851)

* Added support for GraphQL API type

* Added missing enum value for GraphQL APIs.

* add schema definition fix from 2021-01-01-preview (Azure#14883)

Co-authored-by: Alan Feng <[email protected]>

* Vanguard: Get Outbound Network Dependency (Azure#14900)

* outbound dependency

* fix resource

* Update backup/restore API for managed identities (Azure#14973)

* Update backup/restore API for system-assigned and user-assigned identities

* Fix formatting issue

* Rename user-assigned-msi-client-id with client-id

* SystemData implemenation on API Management Control Plane (Azure#14899)

* system-data

* fix spec

* remove unreferenced file

* APIM - Network Watcher Connectivity Check integration specs (Azure#15056)

* Connectivity Check API Specs

* Fix

* Fix errors

* style fixs

* Fix 202 code

* HTTPConnect request parameters

* Fix errors

Co-authored-by: Nicolás Barrera <[email protected]>

* Parameter examples added (Azure#14836)

* platformversion (Azure#15114)

* fix update service (Azure#15478)

* HttpConnect example (Azure#15493)

* HttpConnect example

* Prettifier fix

Co-authored-by: Nicolás Barrera <[email protected]>

* Rename from SchemaContract to ApiSchemaContract

* apimschema.json added to last apim preview version

* Completing specification for Schema resource.
Fixing changes in SchemaContract.

* Value field added to Schema resource specification.

* path fixed.
Renamed from ApiSchema to Schema.
Adding suppression rule to readme.md
Custom word added for spellcheck

* Fixing PR observations.

* Added properties of difference API spec format for "SchemaDocumentProperties" (Azure#15703)

* add schema definition fix from 2021-01-01-preview

* added properties for SchemaDocumentProperties

* updated the fix

* updated fix

* [APIM]Add private endpoint connection APIs (Azure#15115)

* Add private endpoint connection apis

* add readme

* quick fixes

* fix to PE contract

* Small fixes

* small fixes

* small fixes

* Small fixes

* small fixes

* small fix

* small fixes

* small fixes

* small fixes

* Update readme.md

* fix error

* small fix

* fix format

* address comments

* small fixes

* Change to lower case

* small fixes

Co-authored-by: msyyc <[email protected]>

* Adds base for updating Microsoft.ApiManagement from version preview/2021-04-01-preview to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* Merge main

* Modifications to Schema definition to add "description" field.
Updating examples of Schema.

* Fixing apimanagement.json

* Prettier applied in files

* Fixing PR comments

* fixing x-ms-long-running-operation.

* x-ms-long-running-operation : true in apischema.

* Removing "Resource" type from apimanagement.json

* Apimschema.json updated to point to types.json for ErrorResponse.

* Merging from 2021-04-01-preview to 2021-08-01 stable version.

* undoing change of responseBody

* Updating ErrorResponse.

* Fixing definitions merge.

* Changing definitions to fix output of examples.

* Changes in definitions

* Updating response in some examples.

* Rolling back
ApiSchema -> Schema
Schema -> GlobalSchema

* Changes to undo apimapis.json and adding prefix for Global example Schemas.

* Setting x-ms-long-running-operation-options to location.

Co-authored-by: Samir Solanki <[email protected]>
Co-authored-by: Alexander Zaslonov <[email protected]>
Co-authored-by: DreamlessA <[email protected]>
Co-authored-by: Alan Feng <[email protected]>
Co-authored-by: Jatin Sanghvi <[email protected]>
Co-authored-by: Nicolás Barrera <[email protected]>
Co-authored-by: Nicolás Barrera <[email protected]>
Co-authored-by: VitaliyKurokhtin <[email protected]>
Co-authored-by: Christian Palomares <[email protected]>
Co-authored-by: RupengLiu <[email protected]>
Co-authored-by: msyyc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyaaeldeen deyaaeldeen deyaaeldeen approved these changes

@chradek chradek chradek approved these changes

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@xirzec xirzec Awaiting requested review from xirzec

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

@mikeharder mikeharder Awaiting requested review from mikeharder

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

@sarangan12 sarangan12 Awaiting requested review from sarangan12

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joheredi @deyaaeldeen @chradek