Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare @azure/search-documents for June 2021 GA Release #15496

Conversation

sarangan12
Copy link
Contributor

@sarangan12 sarangan12 commented Jun 1, 2021

For this June 2021 release we need to do the following:

  1. Create a separate feature branch for this release (We are not planning to release this from master branch)
  2. Regenerate SDK (Both data and service side) using the latest swagger.
  3. Fix the Custom Code according to the regenerated code. (This will include removal of normalizers, semantic search including speller, etc)

This PR is to follow the above steps. (This PR is similar to Java PR: Azure/azure-sdk-for-java#21909)

@xirzec Please review and approve

@ramya-rao-a FYI....

@sarangan12 sarangan12 requested a review from xirzec June 1, 2021 19:03
@ghost ghost added the Search label Jun 1, 2021
@xirzec
Copy link
Member

xirzec commented Jun 1, 2021

Why can't we release out of master for this? If we're moving it to GA, why keep master as beta?

@sarangan12
Copy link
Contributor Author

Because we are removing the features which are already released in preview version. Also, the July release will have those same features again. We just don't want those features only in this GA.

Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation! I understand the approach now. 👍

@sarangan12 sarangan12 merged commit 6a227f2 into Azure:release/azure-search-documents_11.2.0 Jun 1, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Dec 13, 2021
[DO NOT MERGE]Dev resourcemover microsoft.migrate 2021 08 01 (Azure#15496)

* Adds base for updating Microsoft.Migrate from version stable/2021-01-01 to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* Added systemData property in Move Collection & Move Resource object

* Update resourcemovercollection.json

Added Tags and User-Managed Identities Properties

* Update resourcemovercollection.json

Made changes for removing tags property for document resources and resource group.

* Removed additional empty line

* Swagger PrettierCheck

* Updating examples for 2021-08-01 version.

* CI Fix

Co-authored-by: Anany Shah <[email protected]>
Co-authored-by: yashjain4 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants