-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily reference docs for JS #15749
Daily reference docs for JS #15749
Conversation
eng/common/pipelines/templates/steps/set-daily-docs-branch-name.yml
Outdated
Show resolved
Hide resolved
eng/common/pipelines/templates/steps/update-docsms-metadata.yml
Outdated
Show resolved
Hide resolved
eng/common/pipelines/templates/steps/update-docsms-metadata.yml
Outdated
Show resolved
Hide resolved
eng/common/pipelines/templates/steps/update-docsms-metadata.yml
Outdated
Show resolved
Hide resolved
52e5243
to
c60fe1a
Compare
Co-authored-by: Wes Haggard <[email protected]>
} | ||
} | ||
|
||
$packageMetadataArray = (Get-CSVMetadata).Where({ $_.Package -eq $packageInfo.Name }) | ||
$packageMetadataArray = (Get-CSVMetadata).Where({ $_.Package -eq $packageInfo.Name -and $_.GroupId -eq $packageInfo.Group -and $_.Hide -ne 'true' -and $_.New -eq 'true' }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is going to come into play here yet but if we ever enable strict mode .GroupId will fail because it only exists on some language objects.
-SourceBranch "master" | ||
-DefinitionId 3452 | ||
-Base64EncodedAuthToken "$(azuresdk-apidrop-devops-queue-build-pat)" | ||
-BuildParametersJson '{"params":"{ \"target_repo\": { \"url\": \"https://github.com/MicrosoftDocs/azure-docs-sdk-node\", \"branch\": \"$(DailyDocsBranchName)\", \"folder\": \"./\" }, \"source_repos\": [] }"}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: potential future follow-up, it would be get it storing this as yml and using convertToJson worked on it to make this more readable and maintainable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one last issue related to the link replacement but otherwise I think the rest is good once you have finished your test validation.
…Dev build (pointing to the default branch is preferable and the tag does not exist)
…that don't look like escape sequences to ConvertFrom-Json
…ing Hide == true (e.g. in template packages). The only information consumed from CSV metadata at this time is the service name which gets normalized and placed in the package overview metadata.
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
/azp run js - core - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
The eng/common changes are tracked in PR Azure/azure-sdk-tools#1725
Adds daily reference docs capabilities
Process in action:
SetDevVersion=true
modifying the docs repo -- https://dev.azure.com/azure-sdk/internal/_build/results?buildid=948595&view=results