Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Communication]: Always use x-ms-date for Hmac #15807

Merged
merged 7 commits into from
Jun 18, 2021
Merged

[Communication]: Always use x-ms-date for Hmac #15807

merged 7 commits into from
Jun 18, 2021

Conversation

JianpingChen
Copy link
Member

No description provided.

@ghost ghost added the Communication label Jun 17, 2021
@JianpingChen
Copy link
Member Author

/azp run js - communication-sms - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

beltr0n
beltr0n requested changes Jun 17, 2021
View reviewed changes
Copy link
Member

@beltr0n beltr0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we'll need to re-record recordings?

@JianpingChen
Copy link
Member Author

/azp run js - communication-chat - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-chat - tests

i think we'll need to re-record recordings?

I'm trying to figure that out. It seems the recording only contains response headers not request headers. The Hmac header change is not reflected in the recorded sessions

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@JianpingChen
Copy link
Member Author

/azp run js - communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beltr0n
Copy link
Member

beltr0n commented Jun 17, 2021

/azp run js - communication-chat - tests

i think we'll need to re-record recordings?

I'm trying to figure that out. It seems the recording only contains response headers not request headers. The Hmac header change is not reflected in the recorded sessions

oh yes, only the browser ones will have it, but the header was only different in node

@JianpingChen
Copy link
Member Author

/azp run js - communication-phonenumbers - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@JianpingChen
Copy link
Member Author

/azp run js - communication-phone-numbers - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-network-traversal - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-phone-numbers - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-phone-numbers - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-phone-numbers - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen JianpingChen requested a review from beltr0n June 18, 2021 00:32
@JianpingChen
Copy link
Member Author

/azp run js - communication-sms - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-chat - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-network-traversal - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-network-traversal - tests

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@JianpingChen
Copy link
Member Author

/azp run js - communication-chat - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-sms - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen
Copy link
Member Author

/azp run js - communication-phone-numbers - tests

1 similar comment
@JianpingChen
Copy link
Member Author

/azp run js - communication-phone-numbers - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JianpingChen JianpingChen marked this pull request as ready for review June 18, 2021 19:44
@JianpingChen JianpingChen requested review from ankitarorabit and a team as code owners June 18, 2021 19:44
0rland0Wats0n
0rland0Wats0n approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@0rland0Wats0n 0rland0Wats0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JianpingChen JianpingChen merged commit ddf4714 into Azure:main Jun 18, 2021
@JianpingChen JianpingChen deleted the jiach/updateHamcToUseXMsDate branch June 18, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0rland0Wats0n 0rland0Wats0n 0rland0Wats0n approved these changes

@DominikMe DominikMe Awaiting requested review from DominikMe

@beltr0n beltr0n Awaiting requested review from beltr0n

@ankitarorabit ankitarorabit Awaiting requested review from ankitarorabit

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JianpingChen @beltr0n @0rland0Wats0n