[Identity] Add new StaticTokenCredential #16687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Closed
7 tasks
sadasant
force-pushed
the
identity/fix15803-StaticTokenCredential
branch
from
18fcee5 to
1cfb8ca
Compare
|
This feature is not required in JS. const client = new SecretClient(vaultURI, { getToken: async () => accessToken }); |
I love this. Can we just show this as a sample? |
ghost
pushed a commit
that referenced
this pull request
Sep 1, 2021
This PR comes after the feedback here: #16687 Since there’s a very simple way to satisfy the `TokenCredential` interface, we can help users who want to provide their custom credentials by pointing them to this approach through our docs. Here’s an idea of how we can phrase these docs :) Feedback appreciated 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this look?
Related to this prototype PR (but this one includes many more things): jongio/azidext#41
Related to #15803