Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client type field in GenerateClientTokenOptions interface #30137

Merged
merged 21 commits into from
Aug 1, 2024
Merged

Add client type field in GenerateClientTokenOptions interface #30137

merged 21 commits into from
Aug 1, 2024

Conversation

cqnguy23
Copy link
Member

@cqnguy23 cqnguy23 commented Jun 21, 2024 •
edited
Loading

  1. Support to generate MQTT JWT Token for Azure WebPubSub. Essentially we need to identify if clients want to establish a default WebPubSub connection or an MQTT connection, then we will generate the Client Connection URL for them accordingly.
  • Example Client URL for:
    • Default Connection: wss://exampleHost.com/client/hubs/exampleHub
    • MQTT Connection: wss://exampleHost.com/clients/mqtt/hubs/exampleHub
  1. Upgrade API version to '2024-01-01'
  2. Add tests to get MQTT Token

@cqnguy23 cqnguy23 requested a review from vicancy as a code owner June 21, 2024 09:25
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. WebPubSub labels Jun 21, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @cqnguy23! We will review the pull request and get back to you soon.

@cqnguy23 cqnguy23 changed the title Add client type support Add client type field in GenerateClientTokenOptions interface Jun 21, 2024
Y-Sindo
Y-Sindo reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@Y-Sindo Y-Sindo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to update the doc string for ClientEndpointType after we get reviewed~

@cqnguy23 cqnguy23 requested a review from a team as a code owner July 15, 2024 08:21
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/web-pubsub

@vicancy
Copy link
Member

vicancy commented Jul 18, 2024

@xirzec Hi Jeff, could you help review the PR as well as the APIview? Thanks!

@cqnguy23 cqnguy23 requested a review from maorleger July 22, 2024 16:37
@cqnguy23
Copy link
Member Author

Hi maorleger, could you take a look at the PR again? Thank you

maorleger
maorleger approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM - thanks so much!

@cqnguy23 cqnguy23 merged commit 65faad7 into Azure:main Aug 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-Sindo Y-Sindo Y-Sindo left review comments

@vicancy vicancy vicancy approved these changes

@maorleger maorleger maorleger approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@xirzec xirzec Awaiting requested review from xirzec

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki

@joheredi joheredi Awaiting requested review from joheredi

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. WebPubSub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cqnguy23 @azure-sdk @vicancy @maorleger @Y-Sindo