[@azure/cosmos] Add check for TOP/LIMIT in nonStreamingOrderBy queries #30503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanrao23
requested review from
bterlson,
a team,
kushagraThapar,
kirankumarkolli,
simorenoh and
v1k1
as code owners
|
/run az |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
topshot99
reviewed
Jul 29, 2024
topshot99
reviewed
Jul 29, 2024
sdk/cosmosdb/cosmos/src/queryExecutionContext/pipelinedQueryExecutionContext.ts
Outdated
Show resolved
Hide resolved
topshot99
reviewed
Jul 29, 2024
sdk/cosmosdb/cosmos/src/queryExecutionContext/pipelinedQueryExecutionContext.ts
Outdated
Show resolved
Hide resolved
topshot99
reviewed
Jul 29, 2024
sdk/cosmosdb/cosmos/src/queryExecutionContext/pipelinedQueryExecutionContext.ts
Outdated
Show resolved
Hide resolved
topshot99
reviewed
Jul 31, 2024
sdk/cosmosdb/cosmos/src/queryExecutionContext/pipelinedQueryExecutionContext.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
Describe the problem that is addressed by this PR
This PR removes the support of float 16 from vector embedding data type
This PR adds support to block
nonStreamingOrderByqueries which do not have a TOP or LIMIT+OFFSET present in the query. This check can be disabled by usingallowUnboundedNonStreamingQueriesflag in options.An additional check is placed for internal buffer size. If calculated buffer size is greater than the default buffer size, an error is thrown. This is done as a safeguard from excessive memory consumption. Max buffer size can be increased using
vectorSearchBufferSizein the options.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists