Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[identity] add support for AZURE_CLIENT_SEND_CERTIFICATE_CHAIN env var #30570

Merged
merged 2 commits into from
Jul 30, 2024
Merged

[identity] add support for AZURE_CLIENT_SEND_CERTIFICATE_CHAIN env var #30570

merged 2 commits into from
Jul 30, 2024

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented Jul 30, 2024 •
edited
Loading

Packages impacted by this PR

@azure/identity

Issues associated with this PR

Resolves #29592

Describe the problem that is addressed by this PR

SNI authentication is a 1p certificate feature supported by
ClientCertificateCredential. In order to implement SNI based auth one has to use
ClientCertificateCredential directly instead of DefaultAzureCredential because
there's no way to configure sendCertificateChain from DAC.

For consistency with other languages, we're adding support for
AZURE_CLIENT_SEND_CERTIFICATE_CHAIN as an env var here

Provide a list of related PRs (if any)

Azure/azure-sdk-for-java#41031

Command used to generate this PR: (Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description.
  • Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
  • Added a changelog (if necessary).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@maorleger maorleger marked this pull request as ready for review July 30, 2024 20:27
@maorleger maorleger requested review from schaabs and a team as code owners July 30, 2024 20:27
@maorleger maorleger merged commit f516b58 into Azure:main Jul 30, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarishmaGhiya KarishmaGhiya KarishmaGhiya approved these changes

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@christothes christothes Awaiting requested review from christothes christothes is a code owner automatically assigned from Azure/azure-sdk-write-identity

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-identity

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK inconsistency across langs: support AZURE_CLIENT_SEND_CERTIFICATE_CHAIN from DAC
3 participants
@maorleger @azure-sdk @KarishmaGhiya