-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync eng/common directory with azure-sdk-tools for PR 9102 #31362
Merged
scbedd
merged 16 commits into
main
from
sync-eng/common-feature/enable-ci-artifact-package-property-9102
Oct 11, 2024
Merged
Sync eng/common directory with azure-sdk-tools for PR 9102 #31362
scbedd
merged 16 commits into
main
from
sync-eng/common-feature/enable-ci-artifact-package-property-9102
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a direct function call
…tive to the PSScriptRoot directly
azure-sdk
added
EngSys
This issue is impacting the engineering system.
Central-EngSys
This issue is owned by the Engineering System team.
labels
Oct 10, 2024
…ript-PackageInfoFromRepo
scbedd
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
October 11, 2024 18:41
scbedd
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to make minor changes to actually call the InitializeCIArtifacts() from get-package-properties function.
scbedd
deleted the
sync-eng/common-feature/enable-ci-artifact-package-property-9102
branch
October 11, 2024 20:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Central-EngSys
This issue is owned by the Engineering System team.
EngSys
This issue is impacting the engineering system.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#9102 See eng/common workflow