[storage][test] fix integration by double-quoting file patterns #32584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent Mocha upgrades broke storage integration tests on Windows, likely due to their upgrade of yargs dependency. With single quotes, we now get errors like >Error: No test files found: "'dist-esm/storage-file-share/test/**/*.spec.js'" This PR changes to use escaped doubled quotes in the scripts.
jeremymeng
requested review from
EmmaZhu,
XiaoningLiu,
vinjiang,
jiacfan,
ljian3377 and
blueww
as code owners
|
/azp run js - storage-blob - tests |
|
/azp run js - storage-queue - tests |
|
/azp run js - storage-file-share - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-file-datalake - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
|
Tests failures exist before this PR. |
HarshaNalluru
approved these changes
Jan 17, 2025
|
Logged #32608 |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent Mocha upgrades broke storage integration tests on Windows, likely due to their upgrade of yargs dependency. With single quotes, we now get errors like
This PR changes to use escaped doubled quotes in the scripts.