Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template to depend on core-http #4437

Merged
merged 4 commits into from
Jul 29, 2019
Merged

Update template to depend on core-http #4437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9285938
Update template to depend on core-http
mikeharder Jul 25, 2019
fb81950
Update sdk/template/template/rollup.base.config.js
mikeharder Jul 25, 2019
9e44a3c
Bundle core-http instead of requiring as external
mikeharder Jul 26, 2019
315c681
Update pnpm-lock
mikeharder Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/template/template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"sideEffects": false,
"private": true,
"dependencies": {
"@azure/ms-rest-js": "^1.8.1",
"@azure/core-http": "1.0.0-preview.2",
"events": "^3.0.0",
"tslib": "^1.9.3"
},
Expand Down
2 changes: 1 addition & 1 deletion sdk/template/template/review/template.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
```ts

import EventEmitter from 'events';
import { URLBuilder } from '@azure/ms-rest-js';
import { URLBuilder } from '@azure/core-http';

// @public (undocumented)
export function createEventEmitter(): EventEmitter;
Expand Down
3 changes: 1 addition & 2 deletions sdk/template/template/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,12 @@ export function nodeConfig(test = false) {
export function browserConfig(test = false, production = false) {
const baseConfig = {
input: input,
external: ["@azure/ms-rest-js"],
output: {
file: "browser/azure-template.js",
format: "umd",
name: "ExampleClient",
sourcemap: true,
globals: { "@azure/ms-rest-js": "msRest" }
globals: { "@azure/core-http": "Azure.Core.HTTP" }
},
preserveSymlinks: false,
plugins: [
Expand Down
4 changes: 2 additions & 2 deletions sdk/template/template/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ export { print };

// this is a utility function from a library that should be external
// for both node and web
import { isNode } from "@azure/ms-rest-js";
import { isNode } from "@azure/core-http";

// exporting some value from a dependency
export { URLBuilder } from "@azure/ms-rest-js";
export { URLBuilder } from "@azure/core-http";

export function createEventEmitter() {
// use event emitter
Expand Down