Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev dependency @types/tunnel #4541

Merged
merged 5 commits into from
Jul 31, 2019

Conversation

mikeharder
Copy link
Member

@daviwil: Note the move from dependencies to devDependencies in core-http. I assume having an @types package in regular dependencies is always a mistake?

@daviwil
Copy link
Contributor

daviwil commented Jul 30, 2019

I think the only time it isn't a mistake is if one of those types is being re-exported from the public interface of one of our libraries. I just ran into an issue like that with having @azure/abort-controller as a devDependency of @azure/core-auth. The TypeScript compiler complains about not having access to the AbortSignalLike type that I re-export from @azure/core-auth's public interface. Changing it to a dependency solves the problem.

@daviwil
Copy link
Contributor

daviwil commented Jul 30, 2019

That said, moving @types/tunnel to a devDependency in this PR is the right thing to do as far as I can tell :)

@mikeharder
Copy link
Member Author

mikeharder commented Jul 31, 2019

Follow-up:

@mikeharder mikeharder requested a review from daviwil July 31, 2019 00:33
@mikeharder mikeharder force-pushed the update-types-tunnel branch from 1b87618 to 0356832 Compare July 31, 2019 18:44
@mikeharder mikeharder merged commit cc5636b into Azure:master Jul 31, 2019
@mikeharder mikeharder deleted the update-types-tunnel branch July 31, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants