[app-configuration] Use the x-ms-useragent header when in the browser #6528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, whitelisted the x-ms-useragent header for logging as well since it's the User-Agent header we use for browsers.
richardpark-msft
requested review from
bterlson,
daviwil and
xirzec
as code owners
richardpark-msft
requested review from
bennage and
chradek
and removed request for
bennage
chradek
reviewed
Dec 12, 2019
chradek
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The User-Agent header is not alterable in the browser so we need to fallback to the x-ms-useragent header so we can still send the same information.
This also requires a change on the service backend which won't take effect until January but we will start sending the correct header on next release of the SDK.
Fixes #5810 (for the SDK-side).
(service issue to accept the new header)
Azure/AppConfiguration#217